Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema for creation of framework elements #2492

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

tomgreenfield
Copy link
Contributor

The titles and display titles of newly-created framework elements are wildly inconsistent depending on at which point they are created in the editor.

This PR removes the strings baked into the authoring tool and instead always uses the schema bundled with the currently installed framework.

This is preparatory work for the discussion/implementation of #2481.

Copy link
Contributor

@canstudios-nicolaw canstudios-nicolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@canstudios-nicolaw canstudios-nicolaw merged commit 8c3aa98 into release/bugpatch Feb 3, 2020
@tomgreenfield tomgreenfield deleted the issue/2481 branch February 4, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants