refactor!: use c++20 concept to define insert function for different types of seed collections

[CarloVarni]

Taking from @CouthuresJeremy 's PR I'm here proposing a possible alternative that would not even be a breaking change (unless I'm missing something). This will use c++20 concepts to define different versions of an insert function that will add a seed to the output collection.

This will work with 'back_insert_operator' (as we currently do) as well as collection that support push_back and/or insert

blocked by

• build: Bump minimum required C++ standard to 20 #3345
• ci: Move missing include test from c++17 to c++20 #3377

edit: Now this is breaking since we do not support back_insert_operator option anymore

[CarloVarni]

@paulgessinger @andiwand @CouthuresJeremy I have provided support also for the non C++20 code without changes to the API (if you do not count the change of typename as such?), so this may be already ok to go.

The seed finder and filter now accept a global reference to the seed container (for the current code that is a std:: back_insert_iterator<std::vector<Seed>>) but you can also pass directly std::vector or std::set or anything else. Provided there is an adequate insert function in Acts/Utilities/Functions.hpp that should work.

Also, the signatures of the insert functions should automatically prohibit rvalues for collections such as std::vector or std::set for the C++20 part.

I'll add some tests to check and verify this. But this is good to be reviewed already, I think.

/cc @pbutti who may be interested in seeding developments

[github-actions]

📊: Physics performance monitoring for 517989c

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

Thanks! Let's get this in.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
53.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

🔴 Athena integration test results [88c1223]

Build job with this PR failed!

Please investigate the build job for the pipeline!