remove unnecessary method

Core/include/Acts/Seeding/SeedFinder.hpp

@@ -129,31 +129,6 @@ class SeedFinder {
       const sp_range_t& topSPs,
       const Acts::Range1D<float>& rMiddleSPRange) const;
 
-  /// @brief Compatibility method for the new-style seed finding API.
-  ///
-  /// This method models the old-style seeding API where we only need a
-  /// container for the bottom, middle, and top space points. Also, the results
-  /// are returned by value instead of inserted into an inserter.
-  ///
-  /// @note This method is a very simply wrapper around the more modern API.
-  /// @warning The performance of the seeding code is far greater if the new
-  /// API is used, and this is recommended for all new uses which do not
-  /// require backwards-compatibility.
-  ///
-  /// @tparam sp_range_t container type for the seed point collections.
-  /// @param options frequently changing configuration (like beam position)
-  /// @param grid The grid with space points
-  /// @param bottomSPs group of space points to be used as innermost SP in a
-  /// seed.
-  /// @param middleSPs group of space points to be used as middle SP in a seed.
-  /// @param topSPs group of space points to be used as outermost SP in a seed.
-  /// @returns a vector of seeds.
-  template <typename sp_range_t>
-  std::vector<Seed<external_spacepoint_t>> createSeedsForGroup(
-      const Acts::SeedFinderOptions& options, const grid_t& grid,
-      const sp_range_t& bottomSPs, const std::size_t middleSPs,
-      const sp_range_t& topSPs) const;
-
  private:
   /// Iterates over dublets and tests the compatibility between them by applying
   /// a series of cuts that can be tested with only two SPs

Core/include/Acts/Seeding/SeedFinder.ipp

@@ -843,19 +843,4 @@ SeedFinder<external_spacepoint_t, grid_t, platform_t>::filterCandidates(
   }  // loop on bottoms
 }
 
-template <typename external_spacepoint_t, typename grid_t, typename platform_t>
-template <typename sp_range_t>
-std::vector<Seed<external_spacepoint_t>>
-SeedFinder<external_spacepoint_t, grid_t, platform_t>::createSeedsForGroup(
-    const Acts::SeedFinderOptions& options, const grid_t& grid,
-    const sp_range_t& bottomSPs, const std::size_t middleSPs,
-    const sp_range_t& topSPs) const {
-  SeedingState state;
-  const Acts::Range1D<float> rMiddleSPRange;
-  std::vector<Seed<external_spacepoint_t>> ret;
-  createSeedsForGroup(options, state, grid, std::back_inserter(ret), bottomSPs,
-                      middleSPs, topSPs, rMiddleSPRange);
-
-  return ret;
-}
 }  // namespace Acts

Examples/Algorithms/TrackFinding/src/SeedingAlgorithm.cpp

@@ -320,9 +320,9 @@ ActsExamples::ProcessCode ActsExamples::SeedingAlgorithm::execute(
   }
 
   for (const auto [bottom, middle, top] : spacePointsGrouping) {
-    m_seedFinder.createSeedsForGroup(
-        m_cfg.seedFinderOptions, state, spacePointsGrouping.grid(),
-        std::back_inserter(seeds), bottom, middle, top, rMiddleSPRange);
+    m_seedFinder.createSeedsForGroup(m_cfg.seedFinderOptions, state,
+                                     spacePointsGrouping.grid(), seeds, bottom,
+                                     middle, top, rMiddleSPRange);
   }
 
   ACTS_DEBUG("Created " << seeds.size() << " track seeds from "

docs/core/reconstruction/pattern_recognition/seeding.md

@@ -74,9 +74,6 @@ compatibility with interaction point).
 :::{doxygenfunction} Acts::SeedFinder::createSeedsForGroup(const Acts::SeedFinderOptions &options, SeedingState &state, const grid_t &grid, std::back_insert_iterator<container_t<Seed<external_spacepoint_t>>> &&outIt, const sp_range_t &bottomSPs, const std::size_t middleSPs, const sp_range_t &topSPs, const Acts::Range1D<float> &rMiddleSPRange) const
 :::
 
-:::{doxygenfunction} Acts::SeedFinder::createSeedsForGroup(const Acts::SeedFinderOptions &options, const grid_t &grid, const sp_range_t &bottomSPs, const std::size_t middleSPs, const sp_range_t &topSPs) const
-:::
-
 
 For all pairs passing the selection the triplets of bottom-middle-top SPs are formed.
 Each triplet is then confronted with the helix hypothesis. In order to perform calculations