ci: Move missing include test from c++17 to c++20 #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
andiwand
previously approved these changes
Jul 13, 2024
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 35361b3physmon summary
|
|
andiwand
approved these changes
Jul 14, 2024
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…types of seed collections (#3367) Taking from @<!---->CouthuresJeremy 's PR I'm here proposing a possible alternative that would not even be a breaking change (unless I'm missing something). This will use c++20 concepts to define different versions of an `insert` function that will add a seed to the output collection. This will work with 'back_insert_operator' (as we currently do) as well as collection that support `push_back` and/or `insert` blocked by - #3345 - #3377 edit: Now this is breaking since we do not support back_insert_operator option anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm afraid this was left behind when we migrated to c++20