refactor: Rework interactions interface - more explicit params and types #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
+ Coverage 49.58% 49.60% +0.01%
==========================================
Files 453 452 -1
Lines 25517 25515 -2
Branches 11706 11701 -5
==========================================
+ Hits 12653 12656 +3
+ Misses 4581 4579 -2
+ Partials 8283 8280 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…eractions-interface-and-types
|
AMVF physmon is failing for unknown reasons. I experienced this already multiple times - minimal changes not directly related to the AMVF will be amplified greatly. I will try a few things here to nail this down #2370 My guess is that either there is some weird interference because we run the IVF in the same chain or the AMVF is operating on a critical point in our setup which causes vertices to appear/disappear based on small numerical differences which then show up as bigger differences in the hist cmp |
github-actions
bot
added
Infrastructure
…eractions-interface-and-types
Core/include/Acts/Propagator/detail/GenericDenseEnvironmentExtension.hpp
Outdated
Show resolved
Hide resolved
I moved the assertions into the constructor of |
paulgessinger
previously approved these changes
Aug 17, 2023
|
I am not sure where the remaining reference changes are coming from but I will try to pin it down |
benjaminhuth
approved these changes
Aug 21, 2023
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper. replaces #2181 after splitting it up blocked by - #2366 - #2396 - #2398 - #2397
andiwand
added a commit
that referenced
this pull request
Sep 22, 2023
Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray. Here I try to make the interface cleaner and the intersection order stable. blocked by - #2366 - #2368 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <[email protected]> Co-authored-by: Benjamin Huth <[email protected]> Co-authored-by: Paul Gessinger <[email protected]>
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper. replaces acts-project#2181 after splitting it up blocked by - acts-project#2366 - acts-project#2396 - acts-project#2398 - acts-project#2397
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
…2336) Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray. Here I try to make the interface cleaner and the intersection order stable. blocked by - acts-project#2366 - acts-project#2368 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <[email protected]> Co-authored-by: Benjamin Huth <[email protected]> Co-authored-by: Paul Gessinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the interactions interface to be minimal. That means only passing absolute charge and absolute PDG and only where necessary.
At the same time I made the types explicit. For some reason we use
floatall across the interaction code which I kept and made more explicit.also fixes a weird FPE discovered in
pulled these changes out of
blocked by
Particle::qOverPin Fatras simulation #2375convertLandauFwhmToGaussianSigma#2372