-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix AMVF finding with negative cov #2374
Merged
kodiakhq
merged 4 commits into
acts-project:main
from
andiwand:fix-amvf-finding-with-neg-cov
Aug 17, 2023
Merged
fix: Fix AMVF finding with negative cov #2374
kodiakhq
merged 4 commits into
acts-project:main
from
andiwand:fix-amvf-finding-with-neg-cov
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-russo
previously approved these changes
Aug 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 49.57% 49.57% -0.01%
==========================================
Files 453 453
Lines 25513 25514 +1
Branches 11707 11707
==========================================
Hits 12649 12649
- Misses 4579 4580 +1
Partials 8285 8285
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 5540b90physmon summary
|
acts-policybot
bot
dismissed
felix-russo’s stale review
August 16, 2023 13:33
Invalidated by push of a541819
felix-russo
approved these changes
Aug 16, 2023
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Aug 16, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Fails Athena tests
This PR causes a failure in the Athena tests
Infrastructure
Changes to build tools, continous integration, ...
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMVF vertex finding dropped vertex candidates because
isMergedVertex
would returntrue
for negative covariance matrices.The reason why these matrices are negative definite is still unclear but we should not consider them as merged vertices by default I think.
This was the reason why we experienced noisy AMVF physmon diff for mostly unrelated changes because these conditions would flip flop on small numerical changes. A small reproducible example can be found in #2372