Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix AMVF finding with negative cov #2374

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

andiwand
Copy link
Contributor

AMVF vertex finding dropped vertex candidates because isMergedVertex would return true for negative covariance matrices.

The reason why these matrices are negative definite is still unclear but we should not consider them as merged vertices by default I think.

This was the reason why we experienced noisy AMVF physmon diff for mostly unrelated changes because these conditions would flip flop on small numerical changes. A small reproducible example can be found in #2372

felix-russo
felix-russo previously approved these changes Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2374 (5540b90) into main (543bd5a) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
- Coverage   49.57%   49.57%   -0.01%     
==========================================
  Files         453      453              
  Lines       25513    25514       +1     
  Branches    11707    11707              
==========================================
  Hits        12649    12649              
- Misses       4579     4580       +1     
  Partials     8285     8285              
Files Changed Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 40.81% <14.28%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acts-policybot acts-policybot bot dismissed felix-russo’s stale review August 16, 2023 13:33

Invalidated by push of a541819

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Aug 16, 2023
@kodiakhq kodiakhq bot merged commit 1c459a9 into acts-project:main Aug 17, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 17, 2023
@andiwand andiwand deleted the fix-amvf-finding-with-neg-cov branch August 17, 2023 06:48
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 21, 2023
…ma` (#2372)

Pulled out of #2366 to pin down the hash and physmon diff

blocked by
- #2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ... Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants