-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EDM4hep IO #1260
feat: EDM4hep IO #1260
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1260 +/- ##
=======================================
Coverage 47.42% 47.42%
=======================================
Files 375 375
Lines 19788 19788
Branches 9287 9287
=======================================
Hits 9385 9385
Misses 4021 4021
Partials 6382 6382 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a brief glance, but lgtm. Only a few remarks, probably born out of ignorance :)
maybe we can store the barcode in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
on track
acts/machines
with EDM4hepacts/ci-dependencies
with EDM4hepDD4hepDetector
(seeExamples/Detectors/DD4hepDetector/include/ActsExamples/DD4hepDetector/DD4hepDetector.hpp
)off track
DD4hepDetector
Examples/Io/Root/src/RootMaterialTrackReader.cpp
known issues