Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix EDM4hep #6

Merged
merged 9 commits into from
May 23, 2022
Merged

fix EDM4hep #6

merged 9 commits into from
May 23, 2022

Conversation

andiwand
Copy link
Collaborator

@andiwand andiwand commented May 23, 2022 •
edited
Loading

sorry I messed up the build for EDM4hep. I believe this is also the reason why my build worked and yours didn't @paulgessinger 😄 🤦

let's start another round of try and error!

@paulgessinger
Copy link
Member

Who doesn't love a good round of CI trial-and-error. 🥳

@andiwand
Copy link
Collaborator Author

did some refactoring on the go

  • move install directory to workspace
  • divide install and dependency directory
  • split podio and EDM4hep build
  • cleanup

@andiwand
Copy link
Collaborator Author

I hope that was the last round @paulgessinger

merging for now to trigger acts-project/acts#1260

@andiwand andiwand merged commit 02de138 into acts-project:master May 23, 2022
@andiwand andiwand deleted the fix-edm4hep branch May 23, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger Awaiting requested review from paulgessinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andiwand @paulgessinger