feat: EDM4hep IO

.github/workflows/analysis.yml

@@ -21,7 +21,7 @@ env:
 jobs:
   build_debug:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     steps:
       - uses: actions/checkout@v3
 
@@ -63,7 +63,7 @@ jobs:
 
   build_performance:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     if: github.ref == 'refs/heads/main'
     steps:
       - uses: actions/checkout@v3

.github/workflows/builds.yml

@@ -17,7 +17,7 @@ env:
 jobs:
   lcg:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/${{ matrix.image }}:v22
+    container: ghcr.io/acts-project/${{ matrix.image }}:v26
     strategy:
       matrix:
         image:
@@ -90,10 +90,9 @@ jobs:
       - name: Downstream run
         run: ${SETUP} && ./build-downstream/bin/ShowActsVersion
 
-
   linux_ubuntu:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     env:
       INSTALL_DIR: ${{ github.workspace }}/install
       ACTS_LOG_FAILURE_THRESHOLD: WARNING
@@ -114,7 +113,6 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache-linux_ubuntu_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
         # setting CMAKE_CXX_STANDARD=17 is a workaround for a bug in the
         # dd4hep CMake configuration that gets triggered on recent CMake
@@ -130,6 +128,7 @@ jobs:
           -DACTS_BUILD_EVERYTHING=ON
           -DACTS_BUILD_ODD=ON
           -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON
+          -DACTS_BUILD_EXAMPLES_EDM4HEP=ON
           -DACTS_FORCE_ASSERTIONS=ON
           -DACTS_BUILD_ANALYSIS_APPS=ON
 
@@ -170,11 +169,10 @@ jobs:
 
   linux_examples_test:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     needs: [linux_ubuntu]
     env:
       ACTS_LOG_FAILURE_THRESHOLD: FATAL
-
     steps:
       - name: Install git lfs
         run: apt-get install -y git-lfs
@@ -206,11 +204,11 @@ jobs:
           && source build/python/setup.sh
           && export LD_LIBRARY_PATH=$PWD/build/thirdparty/OpenDataDetector/factory:$LD_LIBRARY_PATH
           && pip3 install -r Examples/Python/tests/requirements.txt
-          && pytest -rFs
+          && pytest -v
 
   linux_physmon:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     needs: [linux_ubuntu]
     env:
       ACTS_LOG_FAILURE_THRESHOLD: FATAL
@@ -287,11 +285,9 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache-linux-nodeps_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
-        run: >
+        run: > # diabling ninja because of race condition
           cmake -B build -S .
-          -GNinja
           -DCMAKE_CXX_COMPILER_LAUNCHER=$(find / -type f -name "ccache")
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_CXX_FLAGS=-Werror
@@ -318,7 +314,6 @@ jobs:
         run: >
           ${SETUP} &&
           cmake -B build -S .
-          -GNinja
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_CXX_FLAGS=-Werror
           -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}"
@@ -339,7 +334,6 @@ jobs:
         run: >
           ${SETUP} &&
           cmake -B build-downstream-nodeps -S Tests/DownstreamProjectNodeps
-          -GNinja
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_CXX_FLAGS=-Werror
           -DCMAKE_PREFIX_PATH="${INSTALL_DIR}"
@@ -375,7 +369,6 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
         # setting CMAKE_CXX_STANDARD=17 is a workaround for a bug in the
         # dd4hep CMake configuration that gets triggered on recent CMake
@@ -393,6 +386,7 @@ jobs:
           -DACTS_BUILD_ODD=ON
           -DACTS_LOG_FAILURE_THRESHOLD=WARNING
           -DACTS_FORCE_ASSERTIONS=ON
+          -DACTS_BUILD_EXAMPLES_EDM4HEP=ON
       - name: Build
         run: cmake --build build  --
       - name: Unit tests
@@ -417,9 +411,10 @@ jobs:
         run: cmake --build build-downstream --
       - name: Downstream run
         run: ./build-downstream/bin/ShowActsVersion
+
   cuda:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu1804_cuda:v22
+    container: ghcr.io/acts-project/ubuntu1804_cuda:v26
     steps:
       - uses: actions/checkout@v2
 
@@ -431,7 +426,6 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache-cuda_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
         run: >
           cmake -B build -S .
@@ -444,9 +438,10 @@ jobs:
           -DACTS_BUILD_UNITTESTS=ON
       - name: Build
         run: cmake --build build --
+
   exatrkx:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004_exatrkx:v22
+    container: ghcr.io/acts-project/ubuntu2004_exatrkx:v26
     steps:
       - uses: actions/checkout@v2
 
@@ -458,7 +453,6 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache-exatrkx_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
         run: >
           cmake -B build -S .
@@ -471,9 +465,10 @@ jobs:
           -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON
       - name: Build
         run: cmake --build build --
+
   sycl:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004_oneapi:v22
+    container: ghcr.io/acts-project/ubuntu2004_oneapi:v26
     defaults:
       run:
         shell: bash
@@ -488,7 +483,6 @@ jobs:
           restore-keys: |
             ${{ runner.os  }}-ccache-sycl_${{ env.CCACHE_KEY_SUFFIX }}_
 
-
       - name: Configure
         run: >
           source /opt/intel/oneapi/setvars.sh
@@ -505,9 +499,10 @@ jobs:
         run: >
           source /opt/intel/oneapi/setvars.sh
           && cmake --build build --
+
   docs:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2004:v22
+    container: ghcr.io/acts-project/ubuntu2004:v26
     env:
         DOXYGEN_WARN_AS_ERROR: YES
     steps:

.github/workflows/checks.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   format:
     runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/format10:v22
+    container: ghcr.io/acts-project/format10:v26
     steps:
       - uses: actions/checkout@v3
       - name: Check

.gitlab-ci.yml

@@ -1,6 +1,6 @@
 clang_tidy:
   stage: build
-  image: ghcr.io/acts-project/ubuntu2004:v21
+  image: ghcr.io/acts-project/ubuntu2004:v26
   artifacts:
     paths:
       - src/clang-tidy/
@@ -37,7 +37,7 @@ clang_tidy:
 
 build:
   stage: build
-  image: ghcr.io/acts-project/ubuntu2004_exatrkx:v22
+  image: ghcr.io/acts-project/ubuntu2004_exatrkx:v26
   tags:
     - docker
   variables:
@@ -82,12 +82,11 @@ build:
       -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON
     - cmake --build build --
 
-
 test:
   stage: test
   dependencies:
     - build
-  image: ghcr.io/acts-project/ubuntu2004_exatrkx:v23
+  image: ghcr.io/acts-project/ubuntu2004_exatrkx:v26
   tags:
     - docker-gpu-nvidia
   script:
@@ -98,4 +97,3 @@ test:
     - source build/python/setup.sh
     - nvidia-smi
     - python3 src/Examples/Scripts/Python/exatrkx.py
-

CMakeLists.txt

@@ -50,6 +50,7 @@ option(ACTS_BUILD_ALIGNMENT "Build Alignment package" OFF)
 # examples related options
 option(ACTS_BUILD_EXAMPLES "Build standalone examples" OFF)
 option(ACTS_BUILD_EXAMPLES_DD4HEP "Build DD4hep-based code in the examples" OFF)
+option(ACTS_BUILD_EXAMPLES_EDM4HEP "Build EDM4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_EXATRKX "Build the Exa.TrkX example code" OFF)
 option(ACTS_BUILD_EXAMPLES_GEANT4 "Build Geant4-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_HEPMC3 "Build HepMC3-based code in the examples" OFF)
@@ -92,6 +93,7 @@ set_option_if(ACTS_BUILD_ALIGNMENT ACTS_BUILD_EVERYTHING)
 set_option_if(
   ACTS_BUILD_EXAMPLES
   ACTS_BUILD_EXAMPLES_DD4HEP
+  OR ACTS_BUILD_EXAMPLES_EDM4HEP
   OR ACTS_BUILD_EXAMPLES_GEANT4
   OR ACTS_BUILD_EXAMPLES_HEPMC3
   OR ACTS_BUILD_EXAMPLES_PYTHIA8
@@ -100,7 +102,8 @@ set_option_if(
 # core plugins might be required by examples or depend on each other
 set_option_if(
   ACTS_BUILD_PLUGIN_DD4HEP
-  ACTS_BUILD_EXAMPLES_DD4HEP OR ACTS_BUILD_EVERYTHING)
+  ACTS_BUILD_EXAMPLES_DD4HEP OR ACTS_BUILD_EVERYTHING OR
+  ACTS_BUILD_EXAMPLES_EDM4HEP)
 set_option_if(
   ACTS_BUILD_PLUGIN_TGEO
   ACTS_BUILD_PLUGIN_DD4HEP OR ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
@@ -154,6 +157,7 @@ set(_acts_autodiff_version 0.6)
 set(_acts_boost_version 1.71.0)
 set(_acts_dd4hep_version 1.11)
 set(_acts_actsdd4hep_version 1.0.0)
+set(_acts_edm4hep_version v00-04-01)
 set(_acts_doxygen_version 1.8.15)
 set(_acts_eigen3_version 3.3.7)
 set(_acts_hepmc3_version 3.2.1)
@@ -247,7 +251,6 @@ if(ACTS_BUILD_PLUGIN_DD4HEP)
   else()
     add_subdirectory(thirdparty/actsdd4hep)
   endif()
-
 endif()
 if(ACTS_BUILD_PLUGIN_JSON)
   if(ACTS_USE_SYSTEM_NLOHMANN_JSON)
@@ -298,6 +301,9 @@ if(ACTS_BUILD_EXAMPLES_DD4HEP AND ACTS_BUILD_EXAMPLES_GEANT4)
 elseif(ACTS_BUILD_EXAMPLES_DD4HEP)
   find_package(DD4hep ${_acts_dd4hep_version} REQUIRED CONFIG COMPONENTS DDCore DDDetectors)
 endif()
+if(ACTS_BUILD_EXAMPLES_EDM4HEP)
+  find_package(EDM4HEP REQUIRED CONFIG)
+endif()
 if(ACTS_BUILD_EXAMPLES_GEANT4)
   find_package(Geant4 REQUIRED CONFIG COMPONENTS gdml)
 endif()

Core/include/Acts/EventData/MultiTrajectory.ipp

@@ -60,7 +60,7 @@ inline auto TrackStateProxy<M, ReadOnly>::parameters() const -> Parameters {
     idx = data().ipredicted;
   }
 
-  return Parameters(m_traj->m_params.data.col(idx).data());
+  return Parameters(m_traj->m_params.col(idx).data());
 }
 
 template <size_t M, bool ReadOnly>
@@ -73,7 +73,7 @@ inline auto TrackStateProxy<M, ReadOnly>::covariance() const -> Covariance {
   } else {
     idx = data().ipredicted;
   }
-  return Covariance(m_traj->m_cov.data.col(idx).data());
+  return Covariance(m_traj->m_cov.col(idx).data());
 }
 
 template <size_t M, bool ReadOnly>

Examples/Detectors/DD4hepDetector/include/ActsExamples/DD4hepDetector/DD4hepDetector.hpp

@@ -15,15 +15,23 @@
 #include <memory>
 #include <vector>
 
-struct DD4hepDetector : public ActsExamples::IBaseDetector {
+namespace ActsExamples {
+namespace DD4hep {
+
+struct DD4hepDetector : public IBaseDetector {
+  std::shared_ptr<DD4hepGeometryService> geometryService;
+
   void addOptions(
       boost::program_options::options_description& opt) const override;
 
-  std::pair<ActsExamples::IBaseDetector::TrackingGeometryPtr, ContextDecorators>
-  finalize(const boost::program_options::variables_map& vm,
-           std::shared_ptr<const Acts::IMaterialDecorator> mdecorator) override;
+  std::pair<IBaseDetector::TrackingGeometryPtr, ContextDecorators> finalize(
+      const boost::program_options::variables_map& vm,
+      std::shared_ptr<const Acts::IMaterialDecorator> mdecorator) override;
 
-  std::pair<ActsExamples::IBaseDetector::TrackingGeometryPtr, ContextDecorators>
-  finalize(ActsExamples::DD4hep::DD4hepGeometryService::Config cfg,
-           std::shared_ptr<const Acts::IMaterialDecorator> mdecorator);
+  std::pair<IBaseDetector::TrackingGeometryPtr, ContextDecorators> finalize(
+      DD4hepGeometryService::Config cfg,
+      std::shared_ptr<const Acts::IMaterialDecorator> mdecorator);
 };
+
+}  // namespace DD4hep
+}  // namespace ActsExamples

Examples/Detectors/DD4hepDetector/src/DD4hepDetector.cpp

@@ -16,6 +16,9 @@
 
 #include <boost/program_options.hpp>
 
+namespace ActsExamples {
+namespace DD4hep {
+
 void DD4hepDetector::addOptions(
     boost::program_options::options_description& opt) const {
   ActsExamples::Options::addDD4hepOptions(opt);
@@ -37,10 +40,10 @@ auto DD4hepDetector::finalize(
     -> std::pair<TrackingGeometryPtr, ContextDecorators> {
   Acts::GeometryContext dd4HepContext;
   config.matDecorator = mdecorator;
-  auto geometrySvc =
+  geometryService =
       std::make_shared<ActsExamples::DD4hep::DD4hepGeometryService>(config);
   TrackingGeometryPtr dd4tGeometry =
-      geometrySvc->trackingGeometry(dd4HepContext);
+      geometryService->trackingGeometry(dd4HepContext);
   if (!dd4tGeometry) {
     throw std::runtime_error{
         "Did not receive tracking geometry from DD4hep geometry service"};
@@ -50,3 +53,6 @@ auto DD4hepDetector::finalize(
   return std::make_pair<TrackingGeometryPtr, ContextDecorators>(
       std::move(dd4tGeometry), std::move(dd4ContextDeocrators));
 }
+
+}  // namespace DD4hep
+}  // namespace ActsExamples

Examples/Io/CMakeLists.txt

@@ -1,4 +1,5 @@
 add_subdirectory(Csv)
+add_subdirectory_if(EDM4hep ACTS_BUILD_EXAMPLES_EDM4HEP)
 add_subdirectory_if(HepMC3 ACTS_BUILD_EXAMPLES_HEPMC3)
 add_subdirectory(Json)
 add_subdirectory(NuclearInteractions)

Examples/Io/Csv/CMakeLists.txt

@@ -13,7 +13,7 @@ add_library(
   src/CsvSpacePointReader.cpp
   src/CsvTrackingGeometryWriter.cpp
   src/CsvMultiTrajectoryWriter.cpp 
-  src/CsvSpacepointWriter.cpp)
+  src/CsvSpacePointWriter.cpp)
 target_include_directories(
   ActsExamplesIoCsv
   PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>)