Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to left sidebar scrollbar #662

Closed
2 tasks done
andrewtavis opened this issue Jan 25, 2024 · 3 comments
Closed
2 tasks done

Edits to left sidebar scrollbar #662

andrewtavis opened this issue Jan 25, 2024 · 3 comments
Assignees
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

As seen in #660, the behavior of the scrollbar for the left sidebar is extremely problematic and we're not going to be able to get close to a good UI without building the scrollbar ourselves (not ideal, but is the situation). The styling should roughly follow the custom CSS class, with the conditions for the sidebar content being scrollable then triggering its appearance in SidebarLeft (see conditions).

Contribution

This is a really important issue. Would be happy for the support, but please understand that we need this to be done very soon. We can also work on this at Code Night 🌙 on Saturday 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -priority- High priority labels Jan 25, 2024
@UnknownSean8 UnknownSean8 mentioned this issue Jan 27, 2024
2 tasks
@andrewtavis
Copy link
Member Author

917712f sent along the base styling for the scrollbar and positioned it appropriately to the left sidebar. We now need the height to be set dynamically given the scroll ratio, and then it needs to be moved given a scroll check :) @UnknownSean8, would you want to take it from here?

@andrewtavis
Copy link
Member Author

CC @rigojr :)

@andrewtavis andrewtavis added the - Code Night 🌙 - Worked on during an activist Code Night 🌙 label Jan 27, 2024
@andrewtavis andrewtavis self-assigned this Apr 20, 2024
@andrewtavis
Copy link
Member Author

Closing this given 9646fa0 and 1f7d931. I've updated the designs so that there's now a gap in scrollbar footer if it's scrollable :) This allows us to use just the normal scrollbar and not have to do a special component for this.

What specifically is needed now is for the margin in the sidebar layout to increase if the content is scrollable, as as of now the width increases and we don't lose the margin completely, but it's smaller than expected.

Thanks for the strong words against this, @rigojr! Nice to be held back from a worm hole 🪱

@andrewtavis andrewtavis removed the - Code Night 🌙 - Worked on during an activist Code Night 🌙 label Apr 20, 2024
@andrewtavis andrewtavis changed the title Create SidebarLeftScrollbar component Edits to left sidebar scrollbar Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant