-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to left sidebar scrollbar #662
Comments
917712f sent along the base styling for the scrollbar and positioned it appropriately to the left sidebar. We now need the height to be set dynamically given the scroll ratio, and then it needs to be moved given a scroll check :) @UnknownSean8, would you want to take it from here? |
CC @rigojr :) |
Closing this given 9646fa0 and 1f7d931. I've updated the designs so that there's now a gap in scrollbar footer if it's scrollable :) This allows us to use just the normal scrollbar and not have to do a special component for this. What specifically is needed now is for the margin in the sidebar layout to increase if the content is scrollable, as as of now the width increases and we don't lose the margin completely, but it's smaller than expected. Thanks for the strong words against this, @rigojr! Nice to be held back from a worm hole 🪱 |
Terms
Description
As seen in #660, the behavior of the scrollbar for the left sidebar is extremely problematic and we're not going to be able to get close to a good UI without building the scrollbar ourselves (not ideal, but is the situation). The styling should roughly follow the custom CSS class, with the conditions for the sidebar content being scrollable then triggering its appearance in SidebarLeft (see conditions).
Contribution
This is a really important issue. Would be happy for the support, but please understand that we need this to be done very soon. We can also work on this at Code Night 🌙 on Saturday 😊
The text was updated successfully, but these errors were encountered: