Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left sidebar content overflows on Firefox (sometimes) #660

Closed
2 tasks done
andrewtavis opened this issue Jan 24, 2024 · 5 comments
Closed
2 tasks done

Left sidebar content overflows on Firefox (sometimes) #660

andrewtavis opened this issue Jan 24, 2024 · 5 comments
Assignees
Labels
-priority- High priority bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jan 24, 2024

Terms

Behavior

There's been a consistent issue with the left sidebar content in Firefox that sometimes the content overflows over the right side and sometimes it doesn't. See an example of when it's problematic below for activist.org/organizations/123/about:

Screenshot 2024-01-17 at 01 11 38

Some details on this:

  • I do not see this on Firefox on Mac, but another person does (above screenshot is from a Mac)
  • I do see this on Firefox on Linux
  • Another contributor sees this on Windows

It would be really great to get some support from someone for this! Happy to assist as needed or get to it myself in a little bit :)

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers -priority- High priority labels Jan 24, 2024
@andrewtavis
Copy link
Member Author

For someone to work on this, it'd be great if they'd confirm that they can reproduce the error as it's not gonna be very effective if they can't :)

@atilagulers
Copy link

I'll check it!

@atilagulers
Copy link

I looked but I didn't encounter any bugs :)

@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 25, 2024

Hey @atilagulers 👋 Appreciate you taking a look at this! I decided to give it a go after a core team meeting we just had :) The above commits make progress on this, but ultimately we still have some serious problems that might not be able to be fixed given the current implementation.

To document my findings:

  • A fundamental problem here is differences between scrollbar behavior in Chromium based browsers and Firefox
    • Properties for the Tailwind scrollbar extension we're using cannot be applied to each
    • Widths are not consistent
    • Padding of the scrollbar thumb to its track is not consistent
  • Specifically for Firefox
    • Different distributions behave differently with some having unintended hover actions on the scrollbar, differences in margins being applied, and countless other minor details that mean that universal alignment is impossible

What's been done:

  • We're no longer checking for Firefox, but rather if the field is scrollable
  • We're checking whether the left sidebar content is scrollable on mouse entry, leave and when the toggle is pressed
  • Dimensions have been changed so that they're not perfect for anything, but not completely out of line as before
  • Many more minor fixes

We seem to be faced with a question of whether we want to make a scrollbar component as there really doesn't seem to be a way to get this working 🤦‍♂️🤦‍♂️

A final check is actually to manually look at what the width of the sidebar content is, and if it's found to be expanding beyond the bounds of the sidebar then to make it more narrow.

@andrewtavis
Copy link
Member Author

After sleeping on this, even the manual check isn't going to help too much in regards to the styling changing on Firefox for Linux. I'll close this and make a custom component issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants