Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sidebar.vue layout margin if the sidebar content is scrollable #825

Closed
2 tasks done
andrewtavis opened this issue Apr 20, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Apr 20, 2024

Terms

Description

in #662 we did various edits to the scrollbar in the left sidebar such that the width of the sidebar will increase to allow the scrollbar to be present and for the content's width to be maintained. One thing that's needed now is for the margin in frontend/layouts/sidebar.vue to increase if the content is scrollable. The needed class options are already in the layout and currently just commented out and waiting to be triggered by a variable that's passed to the layout.

This can be seen on activist.org/organizations/123/about when the content is scrollable (increase the zoom if it's not), where the goal would be that the margin between the sidebar and the page content would be consistent. Screenshots are below:

Screenshot_2024-04-20 15 53 22

Screenshot_2024-04-20 15 53 38

Contribution

Happy to support with this or get to it myself in the future! This is a great good first issue for someone wanting to jump into activist development 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 20, 2024
@andrewtavis andrewtavis self-assigned this Apr 21, 2024
@andrewtavis
Copy link
Member Author

Closed by 89e2392 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant