Fix handling attribute-name with _and_ _or_
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,14 +31,18 @@ def extract(context, key, values) | |||
|
|
|||
| private | |||
|
|
|||
| def extract_attributes_and_predicate(key) | |||
| def extract_attributes_and_predicate(key, context=nil) | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
|
Thanks @hoshitocat! Looks good to me. Could you update the change log with this fix? |
jonatack
added a commit
that referenced
this pull request
Jul 12, 2015
Fix handling attribute-name with `_and_` `_or_`
|
Thank you @jonatack !! |
hoshitocat
added a commit
to hoshitocat/ransack
that referenced
this pull request
Jul 12, 2015
hoshitocat
added a commit
to hoshitocat/ransack
that referenced
this pull request
Jul 12, 2015
jonatack
added a commit
that referenced
this pull request
Jul 13, 2015
Update CHANGELOG with #562 [ci skip]
jonatack
added a commit
that referenced
this pull request
Jul 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve #299
I think Ransack must recognize attribute_name which includes
_and__or_.My approach is:
If the model includes attribute_name, Ransack should recognize it as one attribute_name.
Please feedback this PR !!