Embedded Relations in Mongoid #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `skills_name_cont` is passed in where skills is a embeds_many relation and name is the attribute of the Skill, the attr_name will becomes `skills.name` which will be passed in to the resulting predication query.
|
Thank you @pencilcheck. I don't have Mongoid installed right now. If you add spec coverage, I'm 👍 with trusting your work and merging it in, if it will help people using Ransack with Mongoid. |
jonatack
added a commit
that referenced
this pull request
Jul 12, 2015
Embedded Relations in Mongoid
|
Mongoid users: specs would be welcome! cc @pencilcheck |
|
Sure, I will submit specs when I have more time. Thanks for the reminder. |
jonatack
added a commit
that referenced
this pull request
Jul 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support referenced relations for mongoid in ransack is very difficult due to the fact that mongodb has no joins, therefore I guess might as well start with something that I have a workable solution to.
I have not written any specs for this PR yet, just to throw it out there to see if this is a good idea.