[299] Let attribute names include "and" / "or"

[seanlinsley]

This is my attempt at fixing #299. It works, but likely doesn't cover all scenarios.

The /_and_|_or_/ style logic exists all over the place; for example I know the translation code is still broken in the context of #299. Maybe it'd be better to extract the attribute splitting logic out to a single method that all code would use.

[avit]

The mysql builds are failing... One scenario this won't cover is foo_and_bar_and_baz where the attributes are foo_and_bar, baz.

[avit]

I don't think this is workable unless we change internals to __and__ with double-underscores or such.

Suggest closing this.

[seanlinsley]

I think it'd be perfectly fine to use __and__ internally. Or, we could pass around a hash of queries that itself has already been separated for or/and conditions.

[avit]

Parsed conditions hashes are usable already if you set up your own nested groups of and/or, etc. We should probably document that better in the wiki or provide some helpers for building more complex conditions.

I wouldn't recommend changing the current _and_ format for flat hashes since that could break a ton of client code. (Unless we decide to plan for it with a major breaking version.)

[jonatack]

@seanlinsley Thanks again for this contribution.

I tried your above test to let attribute names include "and" / "or" on the latest Ransack -- and it still fails (see commit 5f8621c today).

So we are not there yet...

[seanlinsley]

Shouldn't this have been resolved by #449?

[jonatack]

Apparently not. The attribute is detected, but the search is not picking up the attribute.

[jonatack]

I tried your test today (see the last commit), and it isn't passing on Ransack master.

[timoschilling]

This PR is should be replaced by #562 (which is merged) and can be closed

[jonatack]

Thanks @timoschilling.