-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Expand cached state disks before running tests #4962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a great finding! Thank you!
This PR is failing as the disk name is too long. I'll be fixing this so we're able to continue with this merge https://github.com/ZcashFoundation/zebra/runs/8050845710?check_suite_focus=true#step:9:75 |
@gustavovalverde I'm happy to fix it, I have a format that will come in under the 63 character limit, but still be unique. |
Oh, I think we were working on the disk name solution in parallel. I have a PR with a similar solution here: #4966 I don't mind if your prefer your solution, but please take into consideration some of the examples I made there as, following the actual name reference in this PR (
Also, keeping the commit does not seem necessary as explained in #4966 as the GITHUB_REF should be enough to find the latest available disk from the PR/branch |
Sorry about that, but I'm happy to be responsible for fixing this one.
This doesn't actually happen with the latest code in this PR, because:
So the actual longest branch name is 63 characters:
Since the branch name is truncated, it's no longer unique, but bug #4842 and accurate search require it to be unique. |
Motivation
In PR #4945, we increased the cached state disk size to 200GB. But that only applies to newly created cached states. (Which take 24 hours to run, and still need fixes like PR #4961.)
So we want to expand older cached state disks to the latest size before using them.
Also fixes #4295.
Solution
Related fixes:
Review
This is urgent because it's stopping all the other PRs from passing.
Reviewer Checklist