Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Write cached state images after update syncs, and use the latest image from any commit #4949

Merged
merged 9 commits into from
Aug 25, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

Zebra's CI is slow, but we can speed it up by:

  • writing images after update syncs
  • using the latest image from any commit on any branch

We haven't seen any problems from sharing images between branches, so test speed is a higher priority.

Also close #4842

Solution

  • Save cached state on full syncs and updates
  • Add an -update suffix to CI images created by updating cached state
  • Make disk image names unique by adding a time suffix
  • Use the latest image from any branch, but prefer the current commit
  • Document Zebra's continuous integration tests

Review

This is an urgent CI speed fix, but it might depend on a successful full sync creating new images on at least one branch.

Reviewer Checklist

  • CI passes and is faster after the first run

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Critical 🚑 I-slow Problems with performance or responsiveness A-state Area: State / database changes labels Aug 25, 2022
@teor2345 teor2345 requested a review from a team as a code owner August 25, 2022 08:01
@teor2345 teor2345 self-assigned this Aug 25, 2022
@teor2345 teor2345 requested a review from a team as a code owner August 25, 2022 08:01
@teor2345 teor2345 requested review from gustavovalverde and oxarbitrage and removed request for a team August 25, 2022 08:01
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0a39011 into main Aug 25, 2022
@mergify mergify bot deleted the reuse-any-cached-state branch August 25, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-state Area: State / database changes C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cached state from the same commit, rather than failing the job
2 participants