Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cached state from the same commit, rather than failing the job #4842

Closed
teor2345 opened this issue Jul 30, 2022 · 0 comments · Fixed by #4949
Closed

Replace cached state from the same commit, rather than failing the job #4842

teor2345 opened this issue Jul 30, 2022 · 0 comments · Fixed by #4949
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures

Comments

@teor2345
Copy link
Contributor

Motivation

If a cached state job is run twice on the same commit on the same branch, the job fails.

If other required jobs depend on that cached state job, they are skipped, and the PR won't merge.

The resource 'projects/zealous-zebra/global/images/lwd-cache-4765-merge-59532a1-v25-mainnet-tip' already exists
Error: Process completed with exit code 1.

https://github.com/ZcashFoundation/zebra/runs/7588987700?check_suite_focus=true#step:8:72

Suggested Solution

Replace the image, rather than failing the job.

If that's not possible, it's also ok to skip creating the image. But the job still has to run successfully. That's not ideal, because it leaves an older (and possibly buggy) cached state image behind.

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Jul 30, 2022
@teor2345 teor2345 self-assigned this Aug 25, 2022
@mergify mergify bot closed this as completed in #4949 Aug 25, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
2 participants