Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tower-batch to tower-batch-control in .github #6914

Closed
2 tasks
teor2345 opened this issue Jun 12, 2023 · 2 comments · Fixed by #7011
Closed
2 tasks

Rename tower-batch to tower-batch-control in .github #6914

teor2345 opened this issue Jun 12, 2023 · 2 comments · Fixed by #7011
Assignees
Labels
A-docs Area: Documentation A-infrastructure Area: Infrastructure changes

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jun 12, 2023

Motivation

In PR #6907, these files got skipped:

  • .github/PULL_REQUEST_TEMPLATE/release-checklist.md
  • .github/CODEOWNERS

This impacts review auto-assignments and the next release after 1.0.0. They are not a release blocker for 1.0.0, so I approved the PR and opened a follow-up ticket.

Originally posted by @teor2345 in #6907 (review)

@mpguerra mpguerra added this to Zebra Jun 12, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Jun 12, 2023
@teor2345 teor2345 changed the title Rename tower-batch in .github Rename tower-batch to tower-batch-control in .github Jun 12, 2023
@teor2345 teor2345 added A-docs Area: Documentation A-infrastructure Area: Infrastructure changes P-Medium ⚡ labels Jun 12, 2023
@teor2345
Copy link
Contributor Author

I did this part so I removed it from the ticket description:

We also need to update the branch protection rules:

  • Admin: Add Build tower-batch-control crate to the main branch protection rules

This might be a testing blocker for 1.0.0.

It's only a blocker if:

  • the tower-batch-control job starts failing, or
  • this crate is modified in another release-blocker PR.

@dconnolly
Copy link
Contributor

Has this been resolved now?

@mpguerra mpguerra linked a pull request Jun 20, 2023 that will close this issue
6 tasks
@mergify mergify bot closed this as completed in #7011 Jun 20, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation A-infrastructure Area: Infrastructure changes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants