Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Rename tower-batch to tower-batch-control #6907

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Jun 9, 2023

Motivation

We want to publish the crates zebrad depends on to crate.io. tower-batch has been taken, so we must rename this crate.

Closes #6202

Solution

Rename tower-batch to tower-batch-control and update all pertinent references.

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

Publish tower-batch-control to crates.io

@dconnolly dconnolly added A-docs Area: Documentation A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Medium ⚡ labels Jun 9, 2023
@dconnolly dconnolly requested review from a team as code owners June 9, 2023 22:33
@dconnolly dconnolly requested review from upbqdn and removed request for a team June 9, 2023 22:33
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #6907 (83acbf2) into main (0c4e1bd) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6907      +/-   ##
==========================================
+ Coverage   77.56%   77.62%   +0.05%     
==========================================
  Files         310      310              
  Lines       41475    41475              
==========================================
+ Hits        32172    32196      +24     
+ Misses       9303     9279      -24     

@teor2345 teor2345 removed request for a team June 11, 2023 21:12
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these files got skipped:

  • .github/PULL_REQUEST_TEMPLATE/release-checklist.md
  • .github/CODEOWNERS

This is not a blocker, so I'm going to merge the rename now, and open a follow-up ticket.

@teor2345
Copy link
Contributor

This needed an update to the branch protection rules. I've removed Build tower-batch crate, we can add Build tower-batch-control crate in after all the critical PRs have merged.

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jun 12, 2023
@teor2345 teor2345 mentioned this pull request Jun 12, 2023
46 tasks
@mergify mergify bot merged commit 8bf2c4b into main Jun 12, 2023
@mergify mergify bot deleted the rename-tower-batch branch June 12, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-docs Area: Documentation A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename tower-batch crate
2 participants