Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(rename): Update missed tower-batch-control renames #7011

Merged
merged 1 commit into from
Jun 20, 2023
Merged

change(rename): Update missed tower-batch-control renames #7011

merged 1 commit into from
Jun 20, 2023

Conversation

dconnolly
Copy link
Contributor

Motivation

We want to clean up any missed config files from the tower-batch -> tower-batch-control rename.

Solution

Rename tower-batch-* in .github/CODEOWNERS, and ???

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@dconnolly dconnolly added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ labels Jun 19, 2023
@github-actions github-actions bot added C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 19, 2023
teor2345
teor2345 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, I checked for other instances of tower-batch and there weren't any:
https://github.com/search?q=repo%3AZcashFoundation%2Fzebra%20tower-batch&type=code

This was linked to issues Jun 20, 2023
Change ContextuallyVerifiedBlockWithTrees into an enum to correctly represent verification statuses #6912
Closed
Rename tower-batch to tower-batch-control in .github #6914
Closed
@mpguerra mpguerra removed a link to an issue Jun 20, 2023
Change ContextuallyVerifiedBlockWithTrees into an enum to correctly represent verification statuses #6912
Closed
@dconnolly dconnolly marked this pull request as ready for review June 20, 2023 22:10
@dconnolly dconnolly requested a review from a team as a code owner June 20, 2023 22:10
@dconnolly dconnolly requested review from upbqdn and removed request for a team June 20, 2023 22:10
mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify
Merge of #7011
e3dd18b
@mergify mergify bot mentioned this pull request Jun 20, 2023
Closed
@mergify mergify bot merged commit 44b7a8b into main Jun 20, 2023
@mergify mergify bot deleted the dconnolly-patch-1 branch June 20, 2023 22:36
arya2 pushed a commit that referenced this pull request Jun 21, 2023
@dconnolly @arya2
change(rename): Update missed tower-batch-control renames (#7011)
7084980
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees
No one assigned
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename tower-batch to tower-batch-control in .github
2 participants
@dconnolly @teor2345