This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk-load): bulk load succeed part2 - meta handle bulk load succeed #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Jun 18, 2020
levy5307
reviewed
Jun 18, 2020
levy5307
reviewed
Jun 18, 2020
acelyc111
reviewed
Jun 22, 2020
acelyc111
reviewed
Jun 22, 2020
levy5307
previously approved these changes
Jun 22, 2020
neverchanje
reviewed
Jun 22, 2020
|
|
||
| bool group_cleaned_up = response.is_group_bulk_load_context_cleaned_up; | ||
| ddebug_f("receive bulk load response from node({}) app({}) partition({}), primary status = {}, " | ||
| "is_group_bulk_load_context_cleaned_up = {}", |
There was a problem hiding this comment.
Please tell a meaningful message in the log so that we can learn what "is_group_bulk_load_context_cleaned_up" means.
There was a problem hiding this comment.
Why the replica group will succeed without their states cleared?
There was a problem hiding this comment.
when partition finish ingesting, its status will turn ingesting -> succeed, meta will still send bulk_load_request to replica, replica will turn ingesting -> succeed and cleanup its bulk load context, replica status should be invalid when it clean up bulk load status not succeed.
neverchanje
previously approved these changes
Jun 22, 2020
|
|
||
| bool group_cleaned_up = response.is_group_bulk_load_context_cleaned_up; | ||
| ddebug_f("receive bulk load response from node({}) app({}) partition({}), primary status = {}, " | ||
| "is_group_bulk_load_context_cleaned_up = {}", |
There was a problem hiding this comment.
Why the replica group will succeed without their states cleared?
neverchanje
previously approved these changes
Jun 23, 2020
acelyc111
previously approved these changes
Jun 23, 2020
levy5307
reviewed
Jun 24, 2020
levy5307
reviewed
Jun 24, 2020
levy5307
approved these changes
Jun 24, 2020
neverchanje
approved these changes
Jun 24, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
Jun 24, 2020
This was referenced Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole bulk load succeed process is like:
This pull request is about meta handle bulk load succeed, step 8 above.
meta handle bulk_load_response in
handle_bulk_load_finish_partitions_cleaned_up[pid] = trueand_apps_in_progress_count[app_id] - 1remove_bulk_load_dir_on_remote_storage), reset local bulk load states(in functionreset_local_bulk_load_states), set app's is_bulk_loading as false (in functionupdate_app_not_bulk_loading_on_remote_storage), whole bulk load process finishedTips:
when app's is_bulk_loading = false, meta will not send bulk load request to replica server any more in function
try_resend_bulk_load_request#463