This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
feat(bulk-load): meta handle bulk_load_response #463
Merged
acelyc111
merged 6 commits into
XiaoMi:master
from
hycdong:meta_on_partition_bulk_load_reply
May 18, 2020
Merged
feat(bulk-load): meta handle bulk_load_response #463
acelyc111
merged 6 commits into
XiaoMi:master
from
hycdong:meta_on_partition_bulk_load_reply
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
May 18, 2020
pid, | ||
err.to_string()); | ||
try_rollback_to_downloading(app_name, pid); | ||
try_resend_bulk_load_request(app_name, pid, interval); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to deal with a nonrecoverable error, e.g. files in remote storage is conrrupt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On L353 ~ L363, the app and partitions' bulk load status will be set as bulk_load_failed (will be implemented in functionhandle_bulk_load_failed
), and resend request to replica server to cleanup bulk load states and context.
acelyc111
previously approved these changes
May 18, 2020
levy5307
reviewed
May 18, 2020
levy5307
approved these changes
May 18, 2020
acelyc111
approved these changes
May 18, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
May 19, 2020
This was referenced Jun 29, 2020
This was referenced Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole bulk load process is like:
This pull request is about meta receive bulk_load_response from primary, the step4 above.
There are two different interval to resend bulk load request to primary. Default value is 10 seconds, short interval is 5 seconds. Short interval will be used when app status is downloaded and ingesting (partition status may be ingesting). If partition is ingesting, meta server wishes to get states faster.
This pull request adds lots of function declarations, and the unit tests will be implemented in further pull request.