fix by review

src/dist/replication/meta_server/meta_bulk_load_service.cpp

@@ -612,6 +612,7 @@ void bulk_load_service::handle_bulk_load_finish(const bulk_load_response &respon
         }
     }
 
+    // The replicas have cleaned up their bulk load states and removed temporary sst files
     bool group_cleaned_up = response.is_group_bulk_load_context_cleaned_up;
     ddebug_f("receive bulk load response from node({}) app({}) partition({}), primary status = {}, "
              "is_group_bulk_load_context_cleaned_up = {}",
@@ -1000,6 +1001,16 @@ void bulk_load_service::remove_bulk_load_dir_on_remote_storage(std::shared_ptr<a
         });
 }
 
+template <typename T>
+inline void erase_map_elem_by_id(int32_t app_id, std::unordered_map<gpid, T> &mymap)
+{
+    for (auto iter = mymap.begin(); iter != mymap.end();) {
+        if (iter->first.get_app_id() == app_id) {
+            mymap.erase(iter++);
+        }
+    }
+}
+
 // ThreadPool: THREAD_POOL_META_STATE
 void bulk_load_service::reset_local_bulk_load_states(int32_t app_id, const std::string &app_name)
 {

src/dist/replication/meta_server/meta_bulk_load_service.h

@@ -43,16 +43,6 @@ struct bulk_load_info
     DEFINE_JSON_SERIALIZATION(app_id, app_name, partition_count)
 };
 
-template <typename T>
-inline void erase_map_elem_by_id(int32_t app_id, std::unordered_map<gpid, T> &mymap)
-{
-    for (auto iter = mymap.begin(); iter != mymap.end();) {
-        if (iter->first.get_app_id() == app_id) {
-            mymap.erase(iter++);
-        }
-    }
-}
-
 ///
 /// Bulk load process:
 /// when client sent `start_bulk_load_rpc` to meta server to start bulk load,
@@ -200,7 +190,7 @@ class bulk_load_service
                                                    bulk_load_status::type new_status,
                                                    bool should_send_request);
 
-    // callled when app is not available or dropped during bulk load, remove bulk load directory on
+    // called when app is not available or dropped during bulk load, remove bulk load directory on
     // remote storage
     void remove_bulk_load_dir_on_remote_storage(int32_t app_id, const std::string &app_name);