Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat: forbid large-size-value writes to Pegasus #414

Merged
merged 20 commits into from
Mar 12, 2020
Merged

feat: forbid large-size-value writes to Pegasus #414

merged 20 commits into from
Mar 12, 2020

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Mar 11, 2020 •
edited by neverchanje
Loading

related issue: apache/incubator-pegasus#490

New Configuration:

[replication]
  max_allowed_write_size = 1048576 # default = 1MB

New perf-counter

eon.replica_stub*recent_write_size_exceed_threshold_count

acelyc111
acelyc111 reviewed Mar 11, 2020
View reviewed changes
src/dist/replication/lib/replica_2pc.cpp Outdated Show resolved Hide resolved
src/dist/replication/lib/replica_2pc.cpp Outdated Show resolved Hide resolved
src/dist/replication/lib/replica_2pc.cpp Show resolved Hide resolved
acelyc111
acelyc111 reviewed Mar 11, 2020
View reviewed changes
src/dist/replication/lib/replica.h Outdated Show resolved Hide resolved
src/dist/replication/lib/replica_2pc.cpp Outdated Show resolved Hide resolved
src/dist/replication/lib/replica_stub.cpp Outdated Show resolved Hide resolved
src/dist/replication/lib/replica_stub.cpp Outdated Show resolved Hide resolved
acelyc111
acelyc111 previously approved these changes Mar 11, 2020
View reviewed changes
levy5307
levy5307 previously approved these changes Mar 12, 2020
View reviewed changes
@neverchanje neverchanje added the type/config-change PR that made modification on configs, which should be noted in release note. label Mar 12, 2020
neverchanje
neverchanje suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration section needs change

@foreverneverer foreverneverer dismissed stale reviews from levy5307 and acelyc111 via 144aea8 March 12, 2020 02:56
@neverchanje neverchanje added the type/perf-counter PR that made modification on perf-counter, which should be noted in release note. label Mar 12, 2020
@acelyc111 acelyc111 merged commit 6af76cf into XiaoMi:master Mar 12, 2020
This was referenced Mar 16, 2020
Closed
Merged
@neverchanje neverchanje mentioned this pull request Mar 30, 2020
Closed
neverchanje pushed a commit that referenced this pull request Mar 31, 2020
@foreverneverer
feat: forbid large-size-value writes to Pegasus (#414)
b6721ce
This was referenced May 12, 2020
Merged
Merged
This was referenced Apr 7, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hycdong hycdong hycdong approved these changes

@neverchanje neverchanje neverchanje approved these changes

@levy5307 levy5307 levy5307 left review comments

@acelyc111 acelyc111 acelyc111 left review comments

Assignees
No one assigned
Labels
1.12.3 type/config-change PR that made modification on configs, which should be noted in release note. type/perf-counter PR that made modification on perf-counter, which should be noted in release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foreverneverer @neverchanje @acelyc111 @hycdong @levy5307