Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid large-size-value writes to Pegasus #490

Closed
neverchanje opened this issue Mar 3, 2020 · 0 comments
Closed

Forbid large-size-value writes to Pegasus #490

neverchanje opened this issue Mar 3, 2020 · 0 comments
Labels
type/enhancement Indicates new feature requests

Comments

@neverchanje
Copy link
Contributor

neverchanje commented Mar 3, 2020

Feature Request

Is your feature request related to a problem? Please describe:

large-size-value writes will lead to the instability of Pegasus. We encounter many cases where the client continuously wrote >=1MB value (though in quite low qps) which caused high tail latency of other tables, even caused the program somehow coredump.

Describe the feature you'd like:

Support a configuration (like 'max_allowed_write_size') to limit write size. If the value is larger than 1MB, pegasus server replies with ERR_INVALID_ARGUMENT or other suitable error code.

The better measure is that we can also add limit on java client to avoid invalid request.
related issue XiaoMi/pegasus-java-client#94

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants