Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overload dump_write_request shouldn't auto-reply to client #718

Merged
merged 5 commits into from
Apr 13, 2021
Merged

fix: overload dump_write_request shouldn't auto-reply to client #718

merged 5 commits into from
Apr 13, 2021

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Apr 9, 2021 •
edited
Loading

What problem does this PR solve?

#533 overload dump_write_request for XiaoMi/rdsn#414 and cause the problem that the server will auto-reply to client with ERR_OK, so all the response_client_write after dump_write_request will be ignored for client, it also mean client will always receive ERR_OK, though pass ERR_INVALID_DATA in XiaoMi/rdsn#414.

What is changed and how does it work?

This PR use rpc_holder constructor replace rpc::auto_replayto dump request

Checklist

  • Manual test (add detailed scripts or steps below)
Side effects
  • large write request will be responsed with ERR_INVALID_DATA and throw exception at client side
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@foreverneverer foreverneverer mentioned this pull request Apr 9, 2021
Closed
levy5307
levy5307 previously approved these changes Apr 9, 2021
View reviewed changes
@neverchanje
Copy link
Contributor

Good job. Is there any case of bug caused by this problem?

@foreverneverer
Copy link
Contributor Author

foreverneverer commented Apr 13, 2021 •
edited
Loading

Good job. Is there any case of bug caused by this problem?

dump_request_write is only used for large size limit, I haven't found other case

@foreverneverer foreverneverer merged commit 232a2b7 into apache:master Apr 13, 2021
zhangyifan27 pushed a commit to zhangyifan27/pegasus that referenced this pull request Jun 1, 2021
@foreverneverer @zhangyifan27
fix: overload dump_write_request shouldn't auto-reply to client (apac…
75d2938 
…he#718)
acelyc111 pushed a commit that referenced this pull request Jun 3, 2021
@foreverneverer @acelyc111
fix: overload dump_write_request shouldn't auto-reply to client (#718)
1748ee7
@hycdong hycdong mentioned this pull request Jun 8, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@Smityz
fix(hotkey): add replication_enums of detect_action::QUERY (#718)
00bb368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz left review comments

@levy5307 levy5307 levy5307 approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foreverneverer @neverchanje @levy5307 @Smityz