chore: Manage dependencies #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
anicholls
commented
Mar 25, 2020
package.json
Outdated
| "@babel/preset-env": "^7.3.1", | ||
| "@babel/preset-react": "^7.0.0", | ||
| "@babel/preset-typescript": "^7.1.0", | ||
| "@babel/core": "^7.9.0", |
There was a problem hiding this comment.
Note: These babel upgrades require me to throw out my node_modules every time I go back to an old branch. May want to consider holding off on this for now.
anicholls
force-pushed
the
manage-deps
branch
2 times, most recently
from
81b2a64 to
a6756ca
Compare
| @@ -45,7 +45,7 @@ class TooltipWrapper extends React.Component<{}, TooltipWrapperState> { | |||
| aria-label="Close" | |||
| /> | |||
| </div> | |||
| <Popper open={open} anchorEl={this.state.anchorEl} placement={'top'}> | |||
| <Popper open={open} anchorElement={this.state.anchorEl} placement={'top'}> | |||
There was a problem hiding this comment.
These changes here will conflict with my Tooltip changes, but I can deal with that merge conflict
NicholasBoll
approved these changes
Mar 30, 2020
Due to TS errors
|
Note: Want to get this in the first 4.0 beta release so we're leaving babel upgrades and removal of react-scripts dep to another PR |
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade & remove some dependencies for 4.0
Checklist
Note: For reviewing, it's probably easiest to follow commit by commit rather than looking at files changed