Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove webpack dependency on react-scripts #542

Closed
anicholls opened this issue Mar 31, 2020 · 1 comment
Closed

fix: Remove webpack dependency on react-scripts #542

anicholls opened this issue Mar 31, 2020 · 1 comment
Labels
4.x enhancement New feature or request
Milestone
v4.0.0

Comments

@anicholls
Copy link
Contributor

Storybook 6.0 will require a CRA preset for react-scripts usage and after upgrading to 5.3, we're now seeing warnings in our logs to install this. Preferably we would remove our dependency on react-scripts entirely.

This was evalutated in #533, but we needed to get that merged so it will have to happen in a separate PR
@anicholls anicholls added the enhancement New feature or request label Mar 31, 2020
@anicholls anicholls added this to the v4.0.0 milestone Mar 31, 2020
@jpante jpante added the 4.x label Apr 6, 2020
@anicholls anicholls mentioned this issue Apr 6, 2020
Merged
@anicholls
Copy link
Contributor Author

Closed by #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x enhancement New feature or request
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@anicholls @jpante