Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(badge): Add badge component #566

Merged
merged 16 commits into from
May 13, 2020
Merged

feat(badge): Add badge component #566

merged 16 commits into from
May 13, 2020

Conversation

alanbsmith
Copy link
Member

@alanbsmith alanbsmith commented Apr 14, 2020 •
edited
Loading

Summary

Checklist

  • branch has been rebased on the latest master commit
  • tests are changed or added
  • yarn test passes
  • all (dev)dependencies that the module needs is added to its package.json
  • code has been documented and, if applicable, usage described in README.md
  • module has been added to canvas-kit-react and/or canvas-kit-css universal modules, if
    applicable
  • design approved final implementation
  • a11y approved final implementation
  • code adheres to the API & Pattern guidelines

Additional References

@alanbsmith alanbsmith added the new-component New Component Implementation label Apr 14, 2020
@cypress
Copy link

cypress bot commented Apr 14, 2020 •
edited
Loading


Test summary

317 • 0 • 0 • 0

Run details
Project canvas-kit
Status Passed
Commit 1dd4265 ℹ️
Started May 12, 2020 4:06 AM
Ended May 12, 2020 4:09 AM
Duration 02:59 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

anicholls
anicholls reviewed Apr 14, 2020
View reviewed changes
modules/_labs/badge/css/index.scss Outdated Show resolved Hide resolved
modules/_labs/badge/css/lib/badge.scss Outdated Show resolved Hide resolved
modules/_labs/badge/css/lib/badge.scss Outdated Show resolved Hide resolved
modules/_labs/badge/css/lib/badge.scss Outdated Show resolved Hide resolved
modules/_labs/badge/css/lib/badge.scss Outdated Show resolved Hide resolved
modules/_labs/badge/react/lib/Badge.tsx Outdated Show resolved Hide resolved
modules/_labs/badge/react/package.json Outdated Show resolved Hide resolved
modules/_labs/badge/react/stories/stories_visualTesting.tsx Outdated Show resolved Hide resolved
modules/_labs/badge/react/stories/stories_visualTesting.tsx Outdated Show resolved Hide resolved
modules/_labs/badge/react/stories/stories_visualTesting.tsx Outdated Show resolved Hide resolved
@alanbsmith alanbsmith linked an issue Apr 14, 2020 that may be closed by this pull request
Add Badge component #537
Closed
@alanbsmith alanbsmith force-pushed the ISSUE-537 branch 2 times, most recently from 44a7a8f to 47b5dae Compare April 17, 2020 05:00
@alanbsmith alanbsmith marked this pull request as ready for review April 17, 2020 05:00
@alanbsmith alanbsmith force-pushed the ISSUE-537 branch 2 times, most recently from 2a21f27 to 0d9ca2c Compare April 17, 2020 17:20
anicholls
anicholls reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@anicholls anicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get this moved out of labs and decide on the last API piece (documenting aria-live vs. using a separate NotificationBadge component), this is good to go!

modules/_labs/badge/css/README.md Outdated Show resolved Hide resolved
modules/_labs/badge/css/README.md Outdated Show resolved Hide resolved
modules/_labs/badge/react/README.md Outdated Show resolved Hide resolved
modules/_labs/badge/react/lib/Badge.tsx Outdated Show resolved Hide resolved
modules/_labs/badge/react/README.md Outdated Show resolved Hide resolved
modules/_labs/badge/react/lib/Badge.tsx Outdated Show resolved Hide resolved
modules/_labs/badge/react/README.md Outdated Show resolved Hide resolved
@alanbsmith alanbsmith force-pushed the ISSUE-537 branch 7 times, most recently from 9c0e5bb to f3b10f5 Compare April 27, 2020 15:19
@cypress
Copy link

cypress bot commented Apr 28, 2020 •
edited
Loading


Test summary

206 • 0 • 0 • 0

Run details
Project canvas-kit
Status Passed
Commit c109e0f
Started Apr 28, 2020 3:41 PM
Ended Apr 28, 2020 3:43 PM
Duration 02:17 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@alanbsmith alanbsmith force-pushed the ISSUE-537 branch 3 times, most recently from e178213 to d73e705 Compare May 7, 2020 17:52
alanbsmith and others added 13 commits May 7, 2020 12:26
@lychyi lychyi added the ready for review Code is ready for review label May 11, 2020
@alanbsmith alanbsmith added approved Code has been reviewed and approved (ship it) and removed ready for review Code is ready for review labels May 13, 2020
@alanbsmith alanbsmith merged commit 7a55541 into master May 13, 2020
@alanbsmith alanbsmith deleted the ISSUE-537 branch May 13, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lychyi lychyi lychyi left review comments

@anicholls anicholls anicholls left review comments

@NicholasBoll NicholasBoll NicholasBoll left review comments

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

Assignees
No one assigned
Labels
approved Code has been reviewed and approved (ship it) new-component New Component Implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Badge component
5 participants
@alanbsmith @NicholasBoll @anicholls @mannycarrera4 @lychyi