Remove forked Gutenberg nav block styles for sub menus #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
update/243-removed-forked-gb-nav-styles
branch
from
dccaa41 to
f3a7453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #246, some Gutenberg styles were forked to support navigation block sub menus in older browsers which don't support the
:whereselector.The usage of this has now been removed in Gutenberg 13.9 so the forked styles can be removed.
Screenshots
Safari 13.1:
Testing
global-header-footerstyles to producemu-plugins/blocks/global-header-footer/build/style.css:where, eg. Safari 13.1, Falkon 3.1.0. Use mouse, keyboard, VoiceOver. Compare behaviour with wordpress.org