Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header menu: Check if forked CSS is still necessary #243

Closed
ryelle opened this issue Aug 9, 2022 · 1 comment
Closed

Header menu: Check if forked CSS is still necessary #243

ryelle opened this issue Aug 9, 2022 · 1 comment
Assignees
@adamwoodnz
Labels
[Block] Header & Footer

Comments

@ryelle
Copy link
Contributor

ryelle commented Aug 9, 2022

In #178 & #210, the menu code from Gutenberg was forked and the where selectors were removed for more browser support. See #159.

The :where selectors were mostly removed in WordPress/gutenberg#42967. Once GB 13.9 is released, the forked CSS might not be necessary anymore.

Test out removing that CSS & make sure the header is still usable on older browsers (ex, Chrome 87 & below).
@ryelle ryelle moved this to 📋 To do in WordPress.org Aug 12, 2022
@adamwoodnz adamwoodnz self-assigned this Aug 23, 2022
@adamwoodnz adamwoodnz moved this from 📋 To do to 🏗 In progress in WordPress.org Aug 23, 2022
@ryelle
Copy link
Contributor Author

ryelle commented Aug 29, 2022

Fixed by #254

@ryelle ryelle closed this as completed Aug 29, 2022
@ryelle ryelle moved this from 🏗 In progress to ✅ Done in WordPress.org Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
[Block] Header & Footer
Projects
WordPress.org
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryelle @adamwoodnz