Navigation: Try to keep :where just for paddings #42967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: +7 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
I think this makes perfect sens and among the proposed alternatives this here strikes me as the most sensible. |
scruffian
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
This looks good to me.
It should also be possible to set the padding directly on the blocks themselves rather than just on the links:
"core/navigation-link": {
"spacing": {
"padding" : {
"top" : "10.5em",
"right": "20em",
"bottom": "10.5em",
"left": "20em"
}
}
}
This doesn't work, but that shouldn't stop this PR.
|
Thank you for the review and green check. To me this one feels pretty safe, so I’d like to land it so we can move forward. In the next week, I’d appreciate eyes being kept on the nav block, just in case I missed anything. Notably the click/hover options for opening should work the same. |
This was referenced Aug 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #42964, alternative to #42965.
:wherefor showing/hiding submenus.:wherefor default paddings, fixing a bug where theme.json padding rules wouldn't affect linksThis alternative keeps the
:whererules in place just for the paddings, so that submenus still have some default padding in their boxes, but can still be overridden bytheme.jsonrules such as these:The net result is that default paddings for menus and submenus remain working for browsers that support
:where, and those paddings an be further customized viatheme.json. With custom rules:Without any custom rules, just the defaults:
Why?
The main challenge in #39230 is for submenus to open and close across every browser, remaining functional for older browsers. An argument can be made that default padding rules fall in the "graceful degradation" category, since they are mostly decorative.
Testing Instructions
Please follow testing instructions from #42964, though note that this PR should be safer (if acceptable) than #42965 since navigation block behavior should be mostly unchanged from what it's been for a while.