This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Fix left/right-aligned pullquote spacing #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allancole
approved these changes
Nov 30, 2018
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 14, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole. See #45424. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44201 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 15, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44201 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 15, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44201 git-svn-id: https://core.svn.wordpress.org/branches/5.0@44031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Dec 18, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44305 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 18, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44305 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 19, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: http://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 19, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: https://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Dec 21, 2018
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: http://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the line, the appearance of left/right-aligned pullquote blocks fell out of sync between the front and back end. This PR cleans things back up.
Before:
After:
It also makes a small change to the padding on left/right-aligned cover blocks to make sure they're in sync again too:
Before:
After:
