Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Update Pullquote Block styles for better front/back end consistency #552

Merged
merged 3 commits into from
Nov 11, 2018

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Nov 11, 2018

Adjusts margins and text color of the pullquote block to improve consistency between frontend and the editor.

Text Color

Editor Style Before (All text was gray in the backend)
screen shot 2018-11-11 at 12 38 18 pm

Editor Style After (Quote text is no longer gray)
screen shot 2018-11-11 at 12 38 33 pm

Margins

Before:
margins-before

After:
margins

@kjellr kjellr added the bug Something isn't working label Nov 11, 2018
@kjellr kjellr added this to the RC1 milestone Nov 11, 2018
@kjellr kjellr requested a review from allancole November 11, 2018 18:40
Copy link
Collaborator

@allancole allancole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@allancole allancole merged commit 1d85387 into master Nov 11, 2018
@kjellr kjellr deleted the update/pullquote-block-styles branch November 15, 2018 15:24
kjellr added a commit that referenced this pull request Nov 30, 2018
Somewhere along the line, we lost some of the pullquote margin/padding improvements for left/right-aligned pullquote blocks made in #552 and #559. This commit cleans things back up, and syncs up pullquote display between the front and back end.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants