Added footer translator comment #237

khleomix · 2018-10-22T15:57:02Z

Amendment for task #171 (see PR #188)

@kjellr @grappler please check if this works. Thanks

grappler · 2018-10-23T15:24:10Z

@khleomix Thank you for the change. My comment in #188 was to make aware of the issue of all of the cases in the theme. I did not want to comment on each and every case.

Do you think you could add the translator comments to all of the cases where it is needed?

khleomix · 2018-10-23T15:35:41Z

@grappler got it, was wondering about that as well. Will have to get back to this tomorrow though. Will update. Thanks!

…theme

khleomix · 2018-10-24T08:28:07Z

@grappler please check if I've covered everything. Thanks

grappler

Nearly there. I have added some comments inline

I found the following warnings:

Warning: The string "Edit <span class="screen-reader-text">%s</span>" has 2 different translator comments. (inc/template-tags.php:118)
Warning: The string "%d response" contains placeholders but has no "translators:" comment to clarify their meaning. (template-parts/post/discussion-meta.php:19)
Warning: The string "%d other" contains placeholders but has no "translators:" comment to clarify their meaning. (template-parts/post/discussion-meta.php:20)

grappler · 2018-10-24T10:21:58Z

footer.php

@@ -18,6 +18,7 @@
 		<div class="site-info">
 			<a class="site-name" href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a>,
 			<a href="<?php echo esc_url( __( 'https://wordpress.org/', 'twentynineteen' ) ); ?>" class="imprint">
+				<?php /* translators: %s: CMS name, i.e. WordPress. */ ?>
 				<?php printf( __( 'Proudly powered by %s', 'twentynineteen' ), 'WordPress' ); ?>.


Now that I am looking at the code again I am wondering why the string can't be just "Proudly powered by WordPress". It is not like this theme can be installed in another CMS.

@grappler You're right, I copied that over from the Gutenberg Starter Theme (https://github.com/WordPress/gutenberg-starter-theme/blob/master/footer.php) will update and fix as per your comments.

Sorry, I meant the code should be

_e( 'Proudly powered by WordPress', 'twentynineteen' );

no worries :) added.

grappler · 2018-10-24T10:22:40Z

inc/template-tags.php

@@ -11,8 +11,10 @@
 	 * Prints HTML with meta information for the current post-date/time.
 	 */
 	function twentynineteen_posted_on() {
+		/* translators: 1: post date in Full Date/Time. 2: post date in F j, Y. */
 		$time_string = '<time class="entry-date published updated" datetime="%1$s">%2$s</time>';


There is no internationalization function used here the translator comment is not needed.

grappler · 2018-10-24T10:22:52Z

inc/template-tags.php

 		$time_string = '<time class="entry-date published updated" datetime="%1$s">%2$s</time>';
 		if ( get_the_time( 'U' ) !== get_the_modified_time( 'U' ) ) {
+			/* translators: 1: post date in Full Date/Time. 2: post date in F j, Y. 3: updated post date in Full Date/Time. 2: updated post date in F j Y.  */
 			$time_string = '<time class="entry-date published" datetime="%1$s">%2$s</time><time class="updated" datetime="%3$s">%4$s</time>';


grappler · 2018-10-24T10:22:58Z

inc/template-tags.php

@@ -25,6 +27,7 @@ function twentynineteen_posted_on() {
 		);

 		printf(
+			/* translators: 1: SVG icon, 2: link to post */
 			'<span class="posted-on">%1$s<a href="%2$s" rel="bookmark">' . $time_string . '</a></span>',


grappler · 2018-10-24T10:23:08Z

inc/template-tags.php

 			/* translators: 1: SVG icon. 2: post author, only visible to screen readers. 3: author link. */
+			'<span class="byline">%1$s<span class="screen-reader-text">%2$s</span><span class="author vcard"><a class="url fn n" href="%3$s">%4$s</a></span></span>',


grappler · 2018-10-24T10:25:44Z

template-parts/post/author-info.php

@@ -9,6 +9,7 @@
 if ( (bool) get_the_author_meta( 'description' ) ) : ?>
 <div class="author-description">
 	<h2 class="author-title">
+		<?php /* translators: %s: post author */ ?>
 		<span class="author-heading"><?php echo esc_html( sprintf( __( 'Published by %s', 'twentynineteen' ), get_the_author() ) ); ?></span>


Looks good. Though I would have written the code as

printf( /* translators: %s: post author */ __( 'Published by %s', 'twentynineteen' ), esc_html( get_the_author() ) );

… be consistent with default themes from Twenty Fifteen until Twenty Seventeen

khleomix · 2018-10-24T16:22:28Z

@grappler please recheck and let me know if there are more changes.

grappler

Looks good

dimadin · 2018-10-25T18:39:46Z

template-parts/post/discussion-meta.php

 		sprintf( _n( '%d response', '%d responses', $discussion->responses, 'twentynineteen' ), $discussion->responses ),
+		/* translators: %d(X others)$s */
 		sprintf( _n( '%d other', '%d others', $discussion->commenters, 'twentynineteen' ), $discussion->commenters )


This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. WordPress/twentynineteen#661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 Props khleomix, grapplerulrich, iCaleb, kjellr, allancole. See #45424. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44199 602fd350-edb4-49c9-b593-d223f7449a82

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. WordPress/twentynineteen#661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 Props khleomix, grapplerulrich, iCaleb, kjellr, allancole. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44199 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44029 1a063a9b-81f0-0310-95a4-ce76da25c4cd

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. WordPress/twentynineteen#661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 Props khleomix, grapplerulrich, iCaleb, kjellr, allancole. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44199 git-svn-id: https://core.svn.wordpress.org/branches/5.0@44029 1a063a9b-81f0-0310-95a4-ce76da25c4cd

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44305 602fd350-edb4-49c9-b593-d223f7449a82

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: http://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: https://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core. - Fix the gallery caption link color. WordPress/twentynineteen#687 - Remove left padding from pullquote blocks. WordPress/twentynineteen#690 - Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github .com/WordPress/twentynineteen/pull/47 - Fix and improve some strings with placeholders. WordPress/twentynineteen#217 - Fixes some minor code quality issues. WordPress/twentynineteen#237 - Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github .com/WordPress/twentynineteen/pull/661 - Add missing text domain and escaping to comment author text. WordPress/twentynineteen#274 - Remove hyphens rule for cover image text. WordPress/twentynineteen#691 - Fix left/right-aligned pullquote spacing. WordPress/twentynineteen#695 - Improve `readme.txt` to follow the correct standards for themes. WordPress/twentynineteen#689 Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj. Merges [44196], [44199], and [44201-44202] into trunk. Fixes #45424. Built from https://develop.svn.wordpress.org/trunk@44305 git-svn-id: http://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd

khleomix added 3 commits October 22, 2018 23:50

Added footer translator comment

abf25aa

Merge branch 'master' into fix/footer-placeholder

44b54d3

Merge branch 'master' into fix/footer-placeholder

8b82899

khleomix mentioned this pull request Oct 23, 2018

Cleared TODO comments across all files - task #171 #188

Merged

khleomix added 4 commits October 24, 2018 14:08

Merge remote-tracking branch 'origin' into fix/footer-placeholder

dee0863

fix linting errors

3243c22

added fix to .travis.yml to avoid conflict with stock twentynineteen …

12d9834

…theme

added translator comments where needed

413b87e

grappler suggested changes Oct 24, 2018

View reviewed changes

khleomix added 5 commits October 24, 2018 23:03

Merge branch 'master' into fix/footer-placeholder

9edf57c

took out translator comment as it is not really necessary and also to…

55a6959

… be consistent with default themes from Twenty Fifteen until Twenty Seventeen

took out unnecessary translator comment

fbc857d

rewrote author-title code as per suggestion

66f6633

added translator comments for clarification

09f615f

khleomix added 2 commits October 25, 2018 00:23

Merge branch 'master' into fix/footer-placeholder

ce9cae2

changed Powered by WordPress snippet

b206f95

grappler approved these changes Oct 24, 2018

View reviewed changes

grappler mentioned this pull request Oct 25, 2018

Some small things noted during translation #291

Closed

dimadin reviewed Oct 25, 2018

View reviewed changes

kjellr added the code quality label Nov 8, 2018

allancole added this to the 5.0 milestone Nov 24, 2018

allancole added 3 commits November 29, 2018 14:30

Re-syncing with master

d329a9f

resolving conflicts

a82bb68

Resolving conflicts

3fb4446

allancole merged commit b6a7cc9 into WordPress:master Nov 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added footer translator comment #237

Added footer translator comment #237

khleomix commented Oct 22, 2018

grappler commented Oct 23, 2018

khleomix commented Oct 23, 2018

khleomix commented Oct 24, 2018

grappler left a comment

grappler Oct 24, 2018

khleomix Oct 24, 2018

grappler Oct 24, 2018 •

edited

Loading

khleomix Oct 24, 2018

grappler Oct 24, 2018

grappler Oct 24, 2018

grappler Oct 24, 2018

grappler Oct 24, 2018

grappler Oct 24, 2018

khleomix commented Oct 24, 2018

grappler left a comment

dimadin Oct 25, 2018

		/* translators: 1: SVG icon. 2: post author, only visible to screen readers. 3: author link. */
		'<span class="byline">%1$s<span class="screen-reader-text">%2$s</span><span class="author vcard"><a class="url fn n" href="%3$s">%4$s</a></span></span>',

Added footer translator comment #237

Added footer translator comment #237

Conversation

khleomix commented Oct 22, 2018

grappler commented Oct 23, 2018

khleomix commented Oct 23, 2018

khleomix commented Oct 24, 2018

grappler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grappler Oct 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khleomix commented Oct 24, 2018

grappler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grappler Oct 24, 2018 •

edited

Loading