-
Notifications
You must be signed in to change notification settings - Fork 165
Cleared TODO comments across all files - task #171 #188
Conversation
Thank you for tackling this, @khleomix! I'm seeing a handful of minor Travis errors. Once those are sorted out, this should be good to go. |
@kjellr saw the errors, working on that now. two files from the classes folder are reporting "Missing file doc comment" though |
Looks great! Thanks for the PR, @khleomix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@@ -18,7 +18,6 @@ | |||
<div class="site-info"> | |||
<a class="site-name" href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a>, | |||
<a href="<?php echo esc_url( __( 'https://wordpress.org/', 'twentynineteen' ) ); ?>" class="imprint"> | |||
<?php /* translators: TODO comment on placeholders */ ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have been deleted but a proper comment should have been added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that. Would you mind opening a PR for it by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that. Would you mind opening a PR for it by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contributor: @khleomix
For task #171
Cleared all TODO comments and added header summaries for those that need it. Also, took out header summary period on files that have them.