Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Cleared TODO comments across all files - task #171 #188

Merged
merged 6 commits into from
Oct 19, 2018

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Oct 19, 2018

contributor: @khleomix
For task #171

Cleared all TODO comments and added header summaries for those that need it. Also, took out header summary period on files that have them.

@kjellr
Copy link
Collaborator

kjellr commented Oct 19, 2018

Thank you for tackling this, @khleomix! I'm seeing a handful of minor Travis errors. Once those are sorted out, this should be good to go.

@khleomix
Copy link
Contributor Author

@kjellr saw the errors, working on that now. two files from the classes folder are reporting "Missing file doc comment" though

@kjellr
Copy link
Collaborator

kjellr commented Oct 19, 2018

Looks great! Thanks for the PR, @khleomix!

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kjellr kjellr merged commit e9bc781 into WordPress:master Oct 19, 2018
@khleomix khleomix deleted the task/171 branch October 20, 2018 13:29
@@ -18,7 +18,6 @@
<div class="site-info">
<a class="site-name" href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a>,
<a href="<?php echo esc_url( __( 'https://wordpress.org/', 'twentynineteen' ) ); ?>" class="imprint">
<?php /* translators: TODO comment on placeholders */ ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been deleted but a proper comment should have been added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that. Would you mind opening a PR for it by any chance?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that. Would you mind opening a PR for it by any chance?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that oversight. Would you mind opening a PR to fix that by any chance? If not, feel free to file a new issue and someone will take care of it soon. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grappler @kjellr will open a PR for a fix if it’s not taken care of yet. Thanks for the catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grappler @kjellr will open a PR for a fix if it’s not taken care of yet. Thanks for the catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grappler thanks for the catch. @kjellr will open a PR to fix

@khleomix
Copy link
Contributor Author

@grappler thanks for the catch. @kjellr will open a PR to fix

@khleomix
Copy link
Contributor Author

@kjellr please see: #237 for the fix. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants