Fix PR review reminder DAG for case where base branch is 2+ levels deep #3182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the PR review reminder DAG for the case where a PR depends on a PR 3 levels from main (creating a chain of
branch_beyond -> branch_tertiary -> branch_secondary -> main
). This case can be seen (at the current time) in #3162 which depends on #3161 which depends on #3143 which is pointed at main. For some reason, that many levels out frommain
, there's still some branch protection information but nothing which has the required pull request reviews.Testing Instructions
Run the PR review request reminder DAG locally and see that it succeeds (whereas current runs on
main
are failing).Tests should also pass!
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin