Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreferenced subfields in indices #3162

Merged
merged 24 commits into from
Oct 25, 2023
Merged

Remove unreferenced subfields in indices #3162

merged 24 commits into from
Oct 25, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 7, 2023

Series

This PR is part 3/3

  1. Reduce ES shard count and simplify index properties #3143
  2. Use top-level keyword fields instead of subfields #3161
  3. This PR

Fixes

Fixes #2154 by @sarayourfriend

Description

This PR removes the unreferenced subfields from the ES indices.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Oct 7, 2023
@dhruvkb dhruvkb requested a review from a team as a code owner October 7, 2023 09:30
@dhruvkb dhruvkb requested review from krysal and stacimc and removed request for a team October 7, 2023 09:30
@dhruvkb dhruvkb mentioned this pull request Oct 9, 2023
8 tasks
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvkb dhruvkb added the ⛔ status: blocked Blocked & therefore, not ready for work label Oct 14, 2023
Base automatically changed from smaller_indices_2 to main October 23, 2023 08:58
@dhruvkb dhruvkb merged commit 3f3376c into main Oct 25, 2023
43 checks passed
@dhruvkb dhruvkb deleted the smaller_indices_3 branch October 25, 2023 06:13
@obulat obulat removed the ⛔ status: blocked Blocked & therefore, not ready for work label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: ingestion server Related to the ingestion/data refresh server
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove text mapping on identifier
4 participants