-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use top-level keyword
fields instead of subfields
#3161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested the stats and related endpoints, and license and source filter parameters after rebuilding the images and indexes - everything works fine.
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @stacimc Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @dhruvkb, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM to me. Should we add a blocked
label or otherwise mark this as Do not merge?
For posterity, linking the deployment doc so it's easier to understand what happened here when reviewing in the future.
Series
This PR is part 2/3.
Fixes
Fixes #2154 by @sarayourfriend
Description
This PR updates index usage in the API to not use the keyword-type subfields but rather the parent keyword-type field.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin