Replace media_url with url in provider scripts

[obulat]

Fixes

Fixes #1409 by @stacimc

Description

This PR renames audio_url and image_url in the provider API scripts and ImageStore/AudioStore classes to url, which simplifies the code significantly.

Testing Instructions

The CI should pass. The tests have been updated to use url instead of image_url/audio_url

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[AetherUnbound]

It looks like there's a failing test for the provider data ingester:

 =================================== FAILURES ===================================
_____________________________ test_get_batch_data ______________________________
[gw1] linux -- Python 3.10.10 /usr/local/bin/python

    def test_get_batch_data():
        response_json = _get_resource_json("complete_response.json")
        batch = ingester.get_batch_data(response_json)
    
>       assert batch == EXPECTED_BATCH_DATA
E       AssertionError: assert [{'id': 100, ...le 102', ...}] == [{'id': 100, ...534_web.jpg'}]
E         At index 0 diff: {'id': 100, 'image_url': 'https://openaccess-cdn.clevelandart.org/1916.586.a/1916.586.a_web.jpg', 'media_type': 'image', 'title': 'Title 100', 'url': 'https://clevelandart.org/art/1916.586.a'} != {'id': 100, 'media_type': 'image', 'title': 'Title 100', 'url': 'https://openaccess-cdn.clevelandart.org/1916.586.a/1916.586.a_web.jpg'}
E         Use -v to get more diff

tests/dags/providers/provider_api_scripts/test_provider_data_ingester.py:137: AssertionError
=========================== short test summary info ============================
FAILED tests/dags/providers/provider_api_scripts/test_provider_data_ingester.py::test_get_batch_data

[AetherUnbound]

I'm also getting the following when I run the SMK DAG locally:

[2023-04-25, 00:09:13 UTC] {slack.py:320} INFO - 
*DAG*: `smk_workflow`
*Task*: `ingest_data.pull_image_data`
*Logical Date*: 2023-03-01T00:00:00Z
*Log*: http://localhost:8080/log?execution_date=2023-03-01T00%3A00%3A00%2B00%3A00&task_id=ingest_data.pull_image_data&dag_id=smk_workflow&map_index=-1

*Exception*: ImageStore.add_item() missing 1 required positional argument: 'url'
*Exception Type*: `builtins.TypeError`

It looks like this piece was not updated:

openverse/catalog/dags/providers/provider_api_scripts/smk.py

Line 153 in 96fa262

"image_url": img.get("image_url"),

I think with a change this large, we'll need to be sure we are able to run each affected DAG successfully locally before we deploy it (I wish there was a better way, maybe some ingestion testing in the future!)

[AetherUnbound]

Whew, this is a nice change to see!

[krysal]

@obulat Is this PR ready for review or it is a work in progress?

[obulat]

@obulat Is this PR ready for review or it is a work in progress?

I've rebased it onto the license_info PR, and am going to draft it until that PR is merge. I will run the ingestion for all providers locally after that to check that everything works as expected.

[obulat]

@AetherUnbound, I ran data ingestion locally, and did not get any url-related errors. All but two providers correctly load data. I do get errors in rawpixel (403 response in Airflow, although if I open the link in the browser - it shows results) and iNaturalist (something with local setup in the preingestion tasks).

[AetherUnbound]

This looks great, thanks for testing all the provider scripts! 🙌🏼 I have one thought for a variable rename but it's not blocking.

[AetherUnbound]

Maybe this would be better as image_dimensions?

[openverse-bot]

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@krysal
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)².

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[krysal]

LGTM. Great to have the url column simplified 👏