Consider using url
as field name in provider scripts
#1409
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: catalog
Related to the catalog and Airflow DAGs
Current Situation
Currently in our provider scripts, we use a different field name per media type for the url field -- so,
image_url
andaudio_url
. In the actual database, these all just map tourl
, and so we have to manually convert the field name in each of the associated media stores (example in ImageStore).Suggested Improvement
Unless there's a reason it must be done this way, I'd like to just use
url
everywhere.Benefit
url
, then later pop it off the data and rename it depending on the media type, only for it to just get changed back in the media storeImageData
andAudioData
.Additional context
I'm unaware of the reasoning for the current implementation, so it's possible there's a critical reason why these fields are renamed and we should be sure to test thoroughly.
Implementation
The text was updated successfully, but these errors were encountered: