Paginate GitHub events query for PR reminders #2081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This fixes an issue we found after merging #2027 - an undrafted PR was pinged for review only a day after being ready for review, but the PR message said it was 12 days since the PR was ready (see #1891). After some investigation, we found that this is because the GitHub API defaults to 30 events per page in the events endpoint: https://docs.github.com/en/rest/issues/events?apiVersion=2022-11-28#list-issue-events
Description
This PR adds some very simple pagination to the
get_issue_events
function to enable querying all of the events for a PR prior to determining whether it should be pinged.Testing Instructions
Follow the testing instructions outlined in #2027, but note that #1891 should not be included in the list of PRs to ping.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin