Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Move packages repository into Gutenberg #7556

Merged
merged 457 commits into from
Jul 9, 2018
Merged

Packages: Move packages repository into Gutenberg #7556

merged 457 commits into from
Jul 9, 2018

Conversation

omarreiss
Copy link
Member

@omarreiss omarreiss commented Jun 26, 2018

Description

Adds https://github.com/WordPress/packages/ including all commit history to Gutenberg.

Once this is merged, we need to start moving over issues and PR's from the old repo to Gutenberg as well.

How has this been tested?

I have only tested the script for creating symlinks. Hoping @gziolo could take over from here. 😄

Types of changes

I ran git subtree add --prefix temp-packages https://github.com/WordPress/packages.git master to preserve the commit history. Then I moved the files over to the right directories, synchronized the config files and scripts and removed what was no longer needed.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Adam Silverstein and others added 30 commits September 7, 2017 10:07
Add the WordPress hook library from 21170-core in preparation for beta npm release
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
…-hooks

Correctly enable dashes in regexes in validateNamespace
Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case
# Conflicts:
#	packages/hooks/src/test/index.test.js
#	packages/hooks/src/validateNamespace.js
"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-data|core-blocks|nux)$": "$1",
"@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src"
"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1",
"@wordpress\\/(browserslist-config)$": "packages/$1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this line anymore.

"@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src"
"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1",
"@wordpress\\/(browserslist-config)$": "packages/$1",
"@wordpress\\/(.*)$": "packages/$1/src"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth @youknowriad - do we want to run our tests against src, build or build-module? What if we provide src locally and build-module on Travis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only run src for both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are all good then 👍

@gziolo
Copy link
Member

gziolo commented Jun 28, 2018

Unit tests fail because of the following issue: jestjs/jest#4407:

Using .toThrowErrorMatchingSnapshot() on code that prints error using ansi codes (i.e. using chalk) produces different snapshots if run locally or on CI.

There is a workaround proposed:

https://github.com/joaogranado/jest-serializer-ansi

However, it still fails for us with a really interesting output:

jest-console › console.error › toHaveErroredWith works when not called
[1]
[1] expect(value).toMatchSnapshot()
[1]
[1] Received value does not match stored snapshot 1.
[1]
[1] Compared values have no visual difference.
[1]
[1] 47 | expect(
[1] 48 | () => expect( console ) matcherNameWith
[1] > 49 | ).toThrowErrorMatchingSnapshot();
[1] 50 | } );
[1] 51 |
[1] 52 | test( ${ matcherNameWith } works with many arguments that do not match, () => {
[1]
[1] at Object. (packages/jest-console/src/test/index.test.js:49:8)

In particular Compared values have no visual difference. is puzzling.

@gziolo gziolo requested a review from a team July 9, 2018 07:21
@gziolo gziolo added this to the 3.3 milestone Jul 9, 2018
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gziolo gziolo merged commit caa3fd4 into master Jul 9, 2018
@gziolo gziolo deleted the add-packages branch July 9, 2018 07:39
@omarreiss omarreiss restored the add-packages branch July 9, 2018 08:07
gziolo added a commit that referenced this pull request Jul 9, 2018
gziolo added a commit that referenced this pull request Jul 9, 2018
aaronjorbin added a commit to aaronjorbin/website that referenced this pull request Oct 19, 2018
WordPress archived the packages repo and moved everything into the Gutenberg Project.  See:

WordPress/packages@5e4f4f4
WordPress/gutenberg#7556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript npm Packages Related to npm packages [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants