Packages: Move packages repository into Gutenberg #7556

omarreiss · 2018-06-26T22:19:21Z

Description

Adds https://github.com/WordPress/packages/ including all commit history to Gutenberg.

Once this is merged, we need to start moving over issues and PR's from the old repo to Gutenberg as well.

How has this been tested?

I have only tested the script for creating symlinks. Hoping @gziolo could take over from here. 😄

Types of changes

I ran git subtree add --prefix temp-packages https://github.com/WordPress/packages.git master to preserve the commit history. Then I moved the files over to the right directories, synchronized the config files and scripts and removed what was no longer needed.

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.

Add the WordPress hook library from 21170-core in preparation for beta npm release

- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]

- @wordpress/[email protected]

…-hooks Correctly enable dashes in regexes in validateNamespace

Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case

# Conflicts: # packages/hooks/src/test/index.test.js # packages/hooks/src/validateNamespace.js

gziolo · 2018-06-28T07:07:23Z

test/unit/jest.config.json

-		"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-data|core-blocks|nux)$": "$1",
-		"@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src"
+		"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1",
+		"@wordpress\\/(browserslist-config)$": "packages/$1",


We probably don't need this line anymore.

gziolo · 2018-06-28T07:08:27Z

test/unit/jest.config.json

-		"@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src"
+		"@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1",
+		"@wordpress\\/(browserslist-config)$": "packages/$1",
+		"@wordpress\\/(.*)$": "packages/$1/src"


@aduth @youknowriad - do we want to run our tests against src, build or build-module? What if we provide src locally and build-module on Travis?

I think we should only run src for both.

We are all good then 👍

gziolo · 2018-06-28T09:03:37Z

Unit tests fail because of the following issue: jestjs/jest#4407:

Using .toThrowErrorMatchingSnapshot() on code that prints error using ansi codes (i.e. using chalk) produces different snapshots if run locally or on CI.

There is a workaround proposed:

https://github.com/joaogranado/jest-serializer-ansi

However, it still fails for us with a really interesting output:

jest-console › console.error › toHaveErroredWith works when not called
[1]
[1] expect(value).toMatchSnapshot()
[1]
[1] Received value does not match stored snapshot 1.
[1]
[1] Compared values have no visual difference.
[1]
[1] 47 | expect(
[1] 48 | () => expect( console ) matcherNameWith
[1] > 49 | ).toThrowErrorMatchingSnapshot();
[1] 50 | } );
[1] 51 |
[1] 52 | test( ${ matcherNameWith } works with many arguments that do not match, () => {
[1]
[1] at Object. (packages/jest-console/src/test/index.test.js:49:8)

In particular Compared values have no visual difference. is puzzling.

…d-packages

ntwb

This reverts commit caa3fd4.

…7804) This reverts commit caa3fd4.

WordPress archived the packages repo and moved everything into the Gutenberg Project. See: WordPress/packages@5e4f4f4 WordPress/gutenberg#7556

Adam Silverstein and others added 30 commits September 7, 2017 10:07

camelCase for readme variable names

9f4cefc

update hook and vendor/plugin/function wording, removing Name

73744fa

complte namespace shortening to vendor/plugin/function

7465667

Merge pull request #13 from adamsilverstein/add-wp-hooks

18fed13

Add the WordPress hook library from 21170-core in preparation for beta npm release

Merge branch 'master' of github.com:WordPress/packages

48e6cda

Publish

5b19507

- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]

add publishConfig->access:public for hooks

01902b3

Merge branch 'make-hooks-public'

c45acef

Publish

cc83cde

- @wordpress/[email protected]

correctly enable dashes in regexes in validateNamespace

5ae0096

Export a hooks function enabling adding hooks via composition

5329048

test hooks can be instantiated

7dc5198

Run test on objects instead of globally

8931715

correct data return for Hooks

44c0c6f

Rework the Hooks object, use a local HOOKS instead of global

e9c7002

use object based hooks throughout testing

7c69c03

remove unused global HOOKS

3863e35

remove some logging

3ccbc36

remove extra parts from namespace in tests

76f706a

remov vendor/plugin prefix requirement for namespaces

f552dae

update docs

a71e346

Add a test for “Can add filters with dashes in namespaces”

3b19868

Merge pull request #39 from WordPress/fix/correct-namespace-check-for…

74212b9

…-hooks Correctly enable dashes in regexes in validateNamespace

a11y: Apply .screen-reader-text styles to container

8fffdc8

a11y: Update tests per updated style

49e57d9

Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case

update readme, add some tests

adf8b18

Merge branch 'master' of github.com:WordPress/packages

5aa44bd

Merge branch 'master' into add-hooks-via-composition

4f07420

# Conflicts: # packages/hooks/src/test/index.test.js # packages/hooks/src/validateNamespace.js

switch naming to createHooks and correct tests

b8d5f28

remove extraneous single quotes

031fdfd

gziolo reviewed Jun 28, 2018

View reviewed changes

gziolo added 4 commits June 28, 2018 09:53

Merge remote-tracking branch 'origin/master' into add-packages

56f9852

Packages: Fix configuration with newly introduced packages

cf5acdc

Testing: Try to fix jest-console tests

713980a

Testing: Try to fix jest-console tests

7ec4171

gziolo force-pushed the add-packages branch from 713980a to 7ec4171 Compare June 28, 2018 08:39

ntwb added 2 commits June 28, 2018 19:58

Merge branch 'add-packages' of github.com:WordPress/gutenberg into ad…

aa17df7

…d-packages

jest-preset-default: Alphabetize dependencies

1bc5ff6

nerrad mentioned this pull request Jul 6, 2018

Convert snapshots to use react-test-renderer/shallow (core-blocks/more/test/edit.js) #7756

Merged

4 tasks

gziolo added 2 commits July 6, 2018 23:21

Testing: Use toThrowError matcher for jest-console

af26e94

Merge remote-tracking branch 'origin/master' into add-packages

00b3825

gziolo requested a review from a team July 9, 2018 07:21

gziolo added this to the 3.3 milestone Jul 9, 2018

ntwb approved these changes Jul 9, 2018

View reviewed changes

gziolo merged commit caa3fd4 into master Jul 9, 2018

gziolo deleted the add-packages branch July 9, 2018 07:39

omarreiss restored the add-packages branch July 9, 2018 08:07

gziolo added a commit that referenced this pull request Jul 9, 2018

Revert "Packages: Move packages repository into Gutenberg (#7556)"

38dc6d8

This reverts commit caa3fd4.

This was referenced Jul 9, 2018

Revert "Packages: Move packages repository into Gutenberg" #7804

Merged

Packages: Move packages repository into Gutenberg (2nd try) #7805

Merged

gziolo added a commit that referenced this pull request Jul 9, 2018

Revert "Packages: Move packages repository into Gutenberg (#7556)" (#…

914f381

…7804) This reverts commit caa3fd4.

aduth mentioned this pull request Jul 19, 2018

Fix unexpected behaviour for @wordpress/is-shallow-equal package. #8048

Closed

gziolo mentioned this pull request Jul 23, 2018

Update is-shallow-equal to use ES5 code as before #8132

Merged

4 tasks

aaronjorbin added a commit to aaronjorbin/website that referenced this pull request Oct 19, 2018

Update index.html

6cc6de3

WordPress archived the packages repo and moved everything into the Gutenberg Project. See: WordPress/packages@5e4f4f4 WordPress/gutenberg#7556

aaronjorbin mentioned this pull request Oct 19, 2018

Update WordPress Repository lerna/website#62

Merged

aduth mentioned this pull request Apr 1, 2019

NPM Package JSON Lint Config: Remove is-plain-obj dependency #14751

Merged

gziolo mentioned this pull request Oct 15, 2019

[Monorepo] import gutenberg-mobile as a package #17950

Closed

25 tasks

adamsilverstein mentioned this pull request Jun 4, 2021

Dual-Licensing Gutenberg: Should we keep some code GPL-only #29483

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Packages: Move packages repository into Gutenberg #7556

Packages: Move packages repository into Gutenberg #7556

omarreiss commented Jun 26, 2018 •

edited by gziolo

Loading

gziolo Jun 28, 2018

gziolo Jun 28, 2018

youknowriad Jun 28, 2018

gziolo Jun 28, 2018

gziolo commented Jun 28, 2018 •

edited

Loading

ntwb left a comment

Packages: Move packages repository into Gutenberg #7556

Packages: Move packages repository into Gutenberg #7556

Conversation

omarreiss commented Jun 26, 2018 • edited by gziolo Loading

Description

How has this been tested?

Types of changes

Checklist:

gziolo Jun 28, 2018

Choose a reason for hiding this comment

gziolo Jun 28, 2018

Choose a reason for hiding this comment

youknowriad Jun 28, 2018

Choose a reason for hiding this comment

gziolo Jun 28, 2018

Choose a reason for hiding this comment

gziolo commented Jun 28, 2018 • edited Loading

ntwb left a comment

Choose a reason for hiding this comment

omarreiss commented Jun 26, 2018 •

edited by gziolo

Loading

gziolo commented Jun 28, 2018 •

edited

Loading