-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages: Move packages repository into Gutenberg (2nd try) #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the WordPress hook library from 21170-core in preparation for beta npm release
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
- @wordpress/[email protected]
…-hooks Correctly enable dashes in regexes in validateNamespace
Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case
# Conflicts: # packages/hooks/src/test/index.test.js # packages/hooks/src/validateNamespace.js
It folows the setup of Lerna itself which demonstrates "the golden path of local file: specifiers at scale". See: lerna/lerna#1307.
gziolo
added
Framework
Issues related to broader framework topics, especially as it relates to javascript
[Type] Build Tooling
Issues or PRs related to build tooling
npm Packages
Related to npm packages
labels
Jul 9, 2018
ntwb
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ntwb
pushed a commit
that referenced
this pull request
Jul 10, 2018
This pull request seeks to update `package.json` to apply correct alphabetical ordering to `devDependencies`. This change was observed with a simple `npm install`, likely related to the merge of packages in #7805. **Testing instructions:** Ensure npm installs without issue: ``` npm install ``` Should be no impact on the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Framework
Issues related to broader framework topics, especially as it relates to javascript
npm Packages
Related to npm packages
[Type] Build Tooling
Issues or PRs related to build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2nd try to merge https://github.com/WordPress/packages into Gutenberg. This time hopefully with history preserved, in contrast to #7556 :)