-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monorepo] import gutenberg-mobile as a package #17950
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable batch editing on font change * Remove unnecessary `removeAttribute` call
Release v1.12.0
Merge master (v1.12.0) back to develop
…rg-mobile into add/autosave-monitor * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: [iOS]Fix: Oddly formatted text hangs Gutenberg (WordPress#1352) Remove redundant bg color within button appender (WordPress#1348) Update bundles Update package.json version to 1.12.0 # Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map
…monitor Add "Autosave" bridge methods and enable local auto-save of posts
# Conflicts: # gutenberg
Tug
reviewed
Oct 29, 2019
MOVED TO #18159 since we can not use a fork with Jitpack build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Project Management
Meta-issues related to project management of Gutenberg
[Type] Technical Prototype
Offers a technical exploration into an idea as an example of what's possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explores #11491.
Superseeds #17456 started by @Tug
Wordpress-iOS PR - wordpress-mobile/WordPress-iOS#12762
Wordpress-Android PR - wordpress-mobile/WordPress-Android#10668
This is a migration of gutenberg-mobile to gutenberg repository.
New packages added:
@wordpress/react-native-editor
- playground react-native app and bundle entrypoint@wordpress/react-native-bridge
- module which starts react-native inside the client app (WP-iOS/Android
)@wordpress/react-native-aztec
- react-native-aztec moduleUsual
yarn
commands ran from gutenberg-mobile are now accessible from gutenberg usingnpm run native
For instance:
yarn start
=>npm run native start
How has this been tested?
TBD
Screenshots
Types of changes
Add new native packages, for native build, unifying the 2 repositories
Checklist:
react-native-aztec
example app works