-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid errors when a fontSize preset is not available #65791
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +37 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
410a3ff35a600a509931a497697b455d.mp4
The E2E test failure should be resolved once #65793 is merged.
packages/edit-site/src/components/global-styles/font-sizes/font-size.js
Outdated
Show resolved
Hide resolved
…t-size.js Co-authored-by: Marco Ciampini <[email protected]>
* Avoid errors when the fontSize is not available * remove goBack * Update packages/edit-site/src/components/global-styles/font-sizes/font-size.js --- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: firoz2456 <[email protected]> Co-authored-by: nith53 <[email protected]> Co-authored-by: benniledl <[email protected]>
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 2fc00b8 |
* Avoid errors when the fontSize is not available * remove goBack * Update packages/edit-site/src/components/global-styles/font-sizes/font-size.js --- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: firoz2456 <[email protected]> Co-authored-by: nith53 <[email protected]> Co-authored-by: benniledl <[email protected]>
* Avoid errors when the fontSize is not available * remove goBack * Update packages/edit-site/src/components/global-styles/font-sizes/font-size.js --- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: firoz2456 <[email protected]> Co-authored-by: nith53 <[email protected]> Co-authored-by: benniledl <[email protected]>
What?
Avoid errors when a fontSize preset is not available
Why?
Fixes: #65774
How?
Testing Instructions
Expected result: you should be directed to the typography -> font size presets screen.
Screenshots or screencast