Global styles: leave screen if current shadow entry gets deleted #65935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Size Change: +15 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Oct 8, 2024
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
the
Backport to WP 6.7 Beta/RC
ciampo
commented
Oct 8, 2024
| const updatedShadows = shadows.filter( ( s ) => s.slug !== slug ); | ||
| setShadows( updatedShadows ); | ||
| goTo( `/shadows` ); | ||
| setShadows( shadows.filter( ( s ) => s.slug !== slug ) ); |
There was a problem hiding this comment.
No need to call goTo anymore here, since deleting the shadow will cause the useEffect added above to run, and currentShadow will be undefined
t-hamano
approved these changes
Oct 8, 2024
|
If this PR is rebased the tests should pass. See #65939 |
ciampo
force-pushed
the
fix/global-styles-shadow-panel-reset
branch
from
538994b to
eb9a4aa
Compare
tyxla
approved these changes
Oct 8, 2024
packages/edit-site/src/components/global-styles/shadows-edit-panel.js
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 8, 2024
) * Global styles: leave screen if current shadow entry gets deleted * Refine approach * Apply feedback --- Co-authored-by: ciampo <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: nith53 <[email protected]> Co-authored-by: benniledl <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 8a54551 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…dPress#65935) * Global styles: leave screen if current shadow entry gets deleted * Refine approach * Apply feedback --- Co-authored-by: ciampo <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: nith53 <[email protected]> Co-authored-by: benniledl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65930
This PR prevents the Global Styles "shadow edit" screen from crashing when a user resets the styles while on the screen and editing a custom shadow preset.
Why?
Bug fix
How?
The bug was caused by the fact that the user would be allowed to edit a stale shadow preset, after it had been removed from the global styles.
This PR checks for the current screen shadow to actually exist — and if it doesn't, it navigates back to the parent screen, where all up-to-date shadows are listed.
Testing Instructions
Make sure that the bug flagged in #65930 can't be replicated on this PR.
Screenshots or screencast
Kapture.2024-10-08.at.11.02.18.mp4