Global styles: improve Navigator usage in typography panel #65942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Bug
ciampo
commented
Oct 8, 2024
| @@ -53,10 +53,10 @@ function FontSize() { | |||
|
|
|||
| // Navigate to the font sizes list if the font size is not available. | |||
| useEffect( () => { | |||
| if ( ! fontSize ) { | |||
| goTo( '/typography/font-sizes/', { isBack: true } ); | |||
There was a problem hiding this comment.
Using goTo here was hiding a bug, where goTo was being called twice. The fix is to also check for the slug, which then makes the code only run once
ciampo
commented
Oct 8, 2024
| @@ -302,7 +302,7 @@ function GlobalStylesUI() { | |||
| <ScreenTypography /> | |||
| </GlobalStylesNavigationScreen> | |||
|
|
|||
| <GlobalStylesNavigationScreen path="/typography/font-sizes/"> | |||
| <GlobalStylesNavigationScreen path="/typography/font-sizes"> | |||
There was a problem hiding this comment.
The trailing slash in the path was preventing Navigator from considering /typography/font-sizes/ as a valid parent screen to /typography/font-sizes/:origin/:slug when navigating back. Removing the trailing slack seems to fix the behavior
|
Size Change: -12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
fix/global-styles-navigator-typography
branch
from
8ae4621 to
28ce403
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#65942) * Global styles: remove trailing slack from font sizes screen path * Remove unncessary goTo * Use goBack instead of goTo, add extra slug check to avoid double goBack call --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #65794
Follow up to #65791
This PR improves the usage of the
Navigatorcomponent in the Font Size screen in the Global StylesWhy?
There are a few areas in the font size presets screen where
Navigatoris not being used as expected:goTois being used instead ofgoBack, and it's there to "hide" a bug wheregoTois being called twice inside auseEffectgoTois being called unnecessarily when the user clicks on the "back" button, and is hiding a bug caused by a wrongly formatted screen pathHow?
slug, so that the check inside theuseEffectonly passes once and thus allows us to usegoBackinstead ofgoTopath, which allowsNavigatorto navigate back to the correct screen without the need for the extragoToTesting Instructions
Screenshots or screencast
Kapture.2024-10-08.at.12.21.01.mp4