Editor: Unify the content area of the post and site editors #61860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
May 22, 2024
| @@ -367,7 +364,9 @@ function Layout( { initialPost } ) { | |||
| { ( mode === 'text' || ! isRichEditingEnabled ) && ( | |||
| <TextEditor /> | |||
| ) } | |||
| { ! isLargeViewport && <BlockToolbar hideDragHandle /> } | |||
| { ! isLargeViewport && mode === 'visual' && ( | |||
There was a problem hiding this comment.
Extra check to align with site editor.
youknowriad
commented
May 22, 2024
| @@ -377,9 +376,6 @@ function Layout( { initialPost } ) { | |||
| <MetaBoxes location="advanced" /> | |||
| </div> | |||
| ) } | |||
| { isMobileViewport && sidebarIsOpened && ( | |||
| <ScrollLock /> | |||
There was a problem hiding this comment.
Seems like component was added a long time ago for mobile but it's not present in the site editor and I'm not sure why we need it. Maybe @jasmussen or @ellatrix would know if this removal is impactful or not.
youknowriad
commented
May 22, 2024
| <TemplatePartConverter /> | ||
| <PatternModal /> | ||
| </> | ||
| ) } |
There was a problem hiding this comment.
Most of these don't need to be in the "content" area. So I just moved them to align the content area with the post editor.
youknowriad
commented
May 22, 2024
| <> | ||
| <TemplatePartConverter /> | ||
| <PatternModal /> | ||
| </> |
There was a problem hiding this comment.
I think both of these template part converter and pattern modal components need to move to the editor package. They provide features that are site editor only for now for no obvious reasons.
There was a problem hiding this comment.
PatternModal can definitely move IMO and also move the commands that use them. The template part converter though is probably because we do not allow inserting template parts in posts. Now that both editors are converging, I'm curious if the decision to exclude template parts in post editor should be revisited too..
There was a problem hiding this comment.
We do allow template parts in the template editor which is also available in the post editor. So it should move too.
For the pattern modal, I'm moving it here #61862
For the template part converter, I'm waiting for @jorgefilipecosta's PR that moves the template part creation modal first.
There was a problem hiding this comment.
Hi @youknowriad, that PR is available at #61879.
|
Size Change: -25 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6a8505d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9191362704
|
ntsekouras
reviewed
May 22, 2024
| @@ -273,6 +274,7 @@ export const ExperimentalEditorProvider = withRegistryProvider( | |||
| { type === 'wp_navigation' && ( | |||
| <NavigationBlockEditingMode /> | |||
| ) } | |||
| <EditorKeyboardShortcuts /> | |||
There was a problem hiding this comment.
Should we also move EditorKeyboardShortcutsRegister?
There was a problem hiding this comment.
No, because we want the shortcuts to be registered regardless of whether they are actually applied. Registering the shortcuts allow them to be visible in the keyboard shortcuts modal.
There was a problem hiding this comment.
I still don't get how it would affect the modal if we moved them in Editor provider. Will do some testing to verify 😄
--edit. I tested and it works for me. Maybe I'm testing a different thing? I moved the register in editor/EditorProvider and shortcuts work..
There was a problem hiding this comment.
It works right now because the keyboard shortcuts modal is rendered only when the editor is rendered but in theory the keyboard shortcuts modal should be accessible every time (even in the site editor shell).
I think it's something we can revisit though and the separation between registration and availability in the modal can be reconsidered.
There was a problem hiding this comment.
If we ever reconsider, I think we should just unify the components/registration...
ntsekouras
approved these changes
May 22, 2024
|
There appears to be a small issue with this PR. The root padding broke, somehow:
I found that out by checking the previous commit in https://github.com/WordPress/gutenberg/commits/trunk/?before=f49e0b5958adad9fbd211d5ded07b4cabf5bfec3+51, and that one is fine:
|
|
Thanks for catching that @jasmussen I'll take a look. |
|
@jasmussen Fix here #61906 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…s#61860) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…s#61860) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This is just a small PR that moves some components/elements around in order to prepare for a future potential unification of the whole "content" area of the editor skeleton between post and site editors.
Testing Instructions
There should be no functional change here.